Skip to content

Commit f750415

Browse files
committed
[HttpFoundation] Fix Cookie::isCleared
1 parent 0850b48 commit f750415

File tree

2 files changed

+13
-1
lines changed

2 files changed

+13
-1
lines changed

Cookie.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -183,6 +183,6 @@ public function isHttpOnly()
183183
*/
184184
public function isCleared()
185185
{
186-
return $this->expire < time();
186+
return 0 !== $this->expire && $this->expire < time();
187187
}
188188
}

Tests/CookieTest.php

+12
Original file line numberDiff line numberDiff line change
@@ -153,6 +153,18 @@ public function testCookieIsCleared()
153153
$cookie = new Cookie('foo', 'bar', time() - 20);
154154

155155
$this->assertTrue($cookie->isCleared(), '->isCleared() returns true if the cookie has expired');
156+
157+
$cookie = new Cookie('foo', 'bar');
158+
159+
$this->assertFalse($cookie->isCleared());
160+
161+
$cookie = new Cookie('foo', 'bar', 0);
162+
163+
$this->assertFalse($cookie->isCleared());
164+
165+
$cookie = new Cookie('foo', 'bar', -1);
166+
167+
$this->assertFalse($cookie->isCleared());
156168
}
157169

158170
public function testToString()

0 commit comments

Comments
 (0)