Skip to content

Commit e737770

Browse files
authored
Merge pull request swiftlang#40300 from gwynne/patch-1
Fix input environment not being respected by swift_build_support.shell.run()
2 parents 965f32d + 69e97d2 commit e737770

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

utils/swift_build_support/swift_build_support/shell.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,7 @@ def run(*args, **kwargs):
211211
repo_path = os.getcwd()
212212
echo_output = kwargs.pop('echo', False)
213213
dry_run = kwargs.pop('dry_run', False)
214-
env = kwargs.pop('env', None)
214+
env = kwargs.get('env', None)
215215
prefix = kwargs.pop('prefix', '')
216216
if dry_run:
217217
_echo_command(dry_run, *args, env=env, prompt="{0}+ ".format(prefix))

utils/update_checkout/update_checkout/update_checkout.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -285,7 +285,7 @@ def obtain_additional_swift_sources(pool_args):
285285
skip_history, skip_tags, skip_repository_list) = pool_args
286286

287287
env = dict(os.environ)
288-
env.update({'GIT_TERMINAL_PROMPT': 0})
288+
env.update({'GIT_TERMINAL_PROMPT': '0'})
289289

290290
with shell.pushd(args.source_root, dry_run=False, echo=False):
291291

0 commit comments

Comments
 (0)