Merge pull request #71337 from tshortli/global-concurrent-executor-as-unowned-task-executor-warning

tshortli · web-flow · commit 6d8f6fcef6c7 · 2024-02-02T01:35:00.000-08:00
[TaskExecutors] Add missing return type to `_DefaultGlobalConcurrentExecutor.asUnownedTaskExecutor()`
diff --git a/stdlib/public/Concurrency/GlobalConcurrentExecutor.swift b/stdlib/public/Concurrency/GlobalConcurrentExecutor.swift
@@ -54,7 +54,7 @@ internal final class _DefaultGlobalConcurrentExecutor: TaskExecutor {
     _enqueueJobGlobal(job.context)
   }
 
-  public func asUnownedTaskExecutor() {
+  public func asUnownedTaskExecutor() -> UnownedTaskExecutor {
     // The "default global concurrent executor" is simply the "undefined" one.
     // We represent it as the `(0, 0)` ExecutorRef and it is handled properly
     // by the runtime, without having to call through to the
@@ -63,4 +63,4 @@ internal final class _DefaultGlobalConcurrentExecutor: TaskExecutor {
   }
 }
 
-#endif
+#endif

Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ internal final class _DefaultGlobalConcurrentExecutor: TaskExecutor {`
`54`	`54`	`_enqueueJobGlobal(job.context)`
`55`	`55`	`}`
`56`	`56`
`57`		`- public func asUnownedTaskExecutor() {`
	`57`	`+ public func asUnownedTaskExecutor() -> UnownedTaskExecutor {`
`58`	`58`	`// The "default global concurrent executor" is simply the "undefined" one.`
`59`	`59`	// We represent it as the `(0, 0)` ExecutorRef and it is handled properly
`60`	`60`	`// by the runtime, without having to call through to the`
`@@ -63,4 +63,4 @@ internal final class _DefaultGlobalConcurrentExecutor: TaskExecutor {`
`63`	`63`	`}`
`64`	`64`	`}`
`65`	`65`
`66`		`-#endif`
	`66`	`+#endif`