[region-isolation] Add support for unconditional_checked_cast_addr.

Author: gottesmm

lib/SILOptimizer/Analysis/RegionAnalysis.cpp

@@ -183,10 +183,6 @@ struct UseDefChainVisitor
 /// values. We assert that all instructions that are CONSTANT_TRANSLATION
 /// LookThrough to make sure they stay in sync.
 static bool isStaticallyLookThroughInst(SILInstruction *inst) {
-  if (auto cast = SILDynamicCastInst::getAs(inst))
-    if (cast.isRCIdentityPreserving())
-      return true;
-
   switch (inst->getKind()) {
   default:
     return false;
@@ -225,6 +221,13 @@ static bool isStaticallyLookThroughInst(SILInstruction *inst) {
   case SILInstructionKind::UpcastInst:
   case SILInstructionKind::ValueToBridgeObjectInst:
     return true;
+  case SILInstructionKind::UnconditionalCheckedCastInst: {
+    auto cast = SILDynamicCastInst::getAs(inst);
+    assert(cast);
+    if (cast.isRCIdentityPreserving())
+      return true;
+    return false;
+  }
   }
 }
 
@@ -2324,6 +2327,7 @@ CONSTANT_TRANSLATION(StoreBorrowInst, Store)
 CONSTANT_TRANSLATION(StoreWeakInst, Store)
 CONSTANT_TRANSLATION(MarkUnresolvedMoveAddrInst, Store)
 CONSTANT_TRANSLATION(UncheckedRefCastAddrInst, Store)
+CONSTANT_TRANSLATION(UnconditionalCheckedCastAddrInst, Store)
 
 //===---
 // Ignored
@@ -2451,9 +2455,9 @@ CONSTANT_TRANSLATION(MarkFunctionEscapeInst, Unhandled)
 CONSTANT_TRANSLATION(TestSpecificationInst, Unhandled)
 CONSTANT_TRANSLATION(StoreUnownedInst, Unhandled)
 CONSTANT_TRANSLATION(DeinitExistentialAddrInst, Unhandled)
+CONSTANT_TRANSLATION(PackElementSetInst, Unhandled)
 CONSTANT_TRANSLATION(DeinitExistentialValueInst, Unhandled)
 CONSTANT_TRANSLATION(UnconditionalCheckedCastAddrInst, Unhandled)
-CONSTANT_TRANSLATION(PackElementSetInst, Unhandled)
 
 //===---
 // Apply

test/Concurrency/transfernonsendable_instruction_matching.sil

@@ -1236,3 +1236,29 @@ bb0:
   return %9999 : $()
 }
 
+// Make sure this is a store by erroring on the cast for %a and emitting a
+// second error for %b.
+sil [ossa] @unconditional_checked_cast_addr_test : $@async @convention(thin) () -> () {
+bb0:
+  %a = alloc_stack $NonSendableKlass
+  %b = alloc_stack $NonSendableKlass
+  %initIndirect = function_ref @initIndirect : $@convention(thin) <T> () -> @out T
+  apply %initIndirect<NonSendableKlass>(%a) : $@convention(thin) <T> () -> @out T
+
+  %f = function_ref @transferIndirect : $@convention(thin) @async <τ_0_0> (@in_guaranteed τ_0_0) -> ()
+  apply [caller_isolation=nonisolated] [callee_isolation=global_actor] %f<NonSendableKlass>(%a) : $@convention(thin) @async <τ_0_0> (@in_guaranteed τ_0_0) -> () // expected-warning {{transferring value of non-Sendable type 'NonSendableKlass' from nonisolated context to global actor '<null>'-isolated context}}
+
+  // This is a copy_addr [take] [init] + cast.
+  unconditional_checked_cast_addr NonSendableKlass in %a : $*NonSendableKlass to NonSendableKlass in %b : $*NonSendableKlass // expected-note {{access here could race}}
+
+  apply [caller_isolation=nonisolated] [callee_isolation=global_actor] %f<NonSendableKlass>(%b) : $@convention(thin) @async <τ_0_0> (@in_guaranteed τ_0_0) -> () // expected-warning {{transferring value of non-Sendable type 'NonSendableKlass' from nonisolated context to global actor '<null>'-isolated context}}
+  apply [caller_isolation=nonisolated] [callee_isolation=global_actor] %f<NonSendableKlass>(%b) : $@convention(thin) @async <τ_0_0> (@in_guaranteed τ_0_0) -> () // expected-note {{access here could race}}
+
+  destroy_addr %b : $*NonSendableKlass
+  dealloc_stack %b : $*NonSendableKlass
+  dealloc_stack %a : $*NonSendableKlass
+
+  %9999 = tuple ()
+  return %9999 : $()
+}
+