Skip to content

Add fix-it for a regex that starts or ends with a space #1479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hamishknight opened this issue Mar 31, 2023 · 1 comment · Fixed by #2744
Closed

Add fix-it for a regex that starts or ends with a space #1479

hamishknight opened this issue Mar 31, 2023 · 1 comment · Fixed by #2744
Labels
bug Something isn't working

Comments

@hamishknight
Copy link
Contributor

hamishknight commented Mar 31, 2023 •
edited
Loading

Description

We ought to provide a fix-it for a regex such as / x/ or / x/ to use an extended literal instead e.g #/ x/#. For the space at the start we could also suggest to insert a backslash. This depends on #1463 being merged first.

Steps to Reproduce

No response
@hamishknight hamishknight added the bug Something isn't working label Mar 31, 2023
@hamishknight hamishknight mentioned this issue Mar 31, 2023
Merged
@ahoppen
Copy link
Member

ahoppen commented Mar 31, 2023

rdar://107469888

@AppAppWorks AppAppWorks mentioned this issue Jul 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add fix-its for a bare regex literal with leading and/or trailing spaces AppAppWorks/swift-syntax
2 participants
@ahoppen @hamishknight