Skip to content

Commit acc0320

Browse files
authored
Don’t mutate line endings in assertParseWithAllNewlineEndings (#2100)
My current suspicion is that this is causing swift-syntax CI failures, probably caused by swiftlang/swift#67729. While I investigate what the root cause is, just run a normal `assertParse` here to fix CI.
1 parent b154c3c commit acc0320

File tree

1 file changed

+11
-13
lines changed

1 file changed

+11
-13
lines changed

Tests/SwiftParserTest/translated/MultilineErrorsTests.swift

Lines changed: 11 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -27,19 +27,17 @@ extension ParserTestCase {
2727
file: StaticString = #file,
2828
line: UInt = #line
2929
) {
30-
for newline in ["\n", "\r", "\r\n"] {
31-
assertParse(
32-
markedSource.replacingOccurrences(of: "\n", with: newline),
33-
substructure: expectedSubstructure,
34-
substructureAfterMarker: substructureAfterMarker,
35-
diagnostics: expectedDiagnostics,
36-
applyFixIts: applyFixIts,
37-
fixedSource: expectedFixedSource,
38-
options: [.normalizeNewlinesInFixedSource],
39-
file: file,
40-
line: line
41-
)
42-
}
30+
// FIXME: We should run `assertParse` with every possible line ending here.
31+
assertParse(
32+
markedSource,
33+
substructure: expectedSubstructure,
34+
substructureAfterMarker: substructureAfterMarker,
35+
diagnostics: expectedDiagnostics,
36+
applyFixIts: applyFixIts,
37+
fixedSource: expectedFixedSource,
38+
file: file,
39+
line: line
40+
)
4341
}
4442
}
4543

0 commit comments

Comments
 (0)