Skip to content

Commit 5661e35

Browse files
authored
Merge pull request #2120 from ahoppen/ahoppen/remove-parent-parameter
Remove the `parent` parameter from `SyntaxData.child(at:parent:)`
2 parents 28e00f3 + 152f21c commit 5661e35

File tree

11 files changed

+1703
-1705
lines changed

11 files changed

+1703
-1705
lines changed

CodeGeneration/Sources/generate-swift-syntax/templates/swiftsyntax/SyntaxNodesFile.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -171,9 +171,9 @@ func syntaxNode(nodesStartingWith: [Character]) -> SourceFileSyntax {
171171
) {
172172
AccessorDeclSyntax(accessorSpecifier: .keyword(.get)) {
173173
if child.isOptional {
174-
StmtSyntax("return data.child(at: \(raw: index), parent: Syntax(self)).map(\(childType).init)")
174+
StmtSyntax("return data.child(at: \(raw: index)).map(\(childType).init)")
175175
} else {
176-
StmtSyntax("return \(childType)(data.child(at: \(raw: index), parent: Syntax(self))!)")
176+
StmtSyntax("return \(childType)(data.child(at: \(raw: index))!)")
177177
}
178178
}
179179

Sources/SwiftSyntax/SyntaxData.swift

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -292,10 +292,8 @@ struct SyntaxData {
292292
/// data's layout.
293293
///
294294
/// - Parameter index: The index to create and cache.
295-
/// - Parameter parent: The parent to associate the child with. This is
296-
/// normally the Syntax node that this `SyntaxData` belongs to.
297295
/// - Returns: The child's data at the provided index.
298-
func child(at index: Int, parent: Syntax) -> SyntaxData? {
296+
func child(at index: Int) -> SyntaxData? {
299297
if raw.layoutView!.children[index] == nil { return nil }
300298
var iter = RawSyntaxChildren(absoluteRaw).makeIterator()
301299
for _ in 0..<index { _ = iter.next() }

Sources/SwiftSyntax/generated/syntaxNodes/SyntaxNodesAB.swift

Lines changed: 167 additions & 167 deletions
Large diffs are not rendered by default.

Sources/SwiftSyntax/generated/syntaxNodes/SyntaxNodesC.swift

Lines changed: 197 additions & 197 deletions
Large diffs are not rendered by default.

Sources/SwiftSyntax/generated/syntaxNodes/SyntaxNodesD.swift

Lines changed: 156 additions & 156 deletions
Large diffs are not rendered by default.

Sources/SwiftSyntax/generated/syntaxNodes/SyntaxNodesEF.swift

Lines changed: 217 additions & 217 deletions
Large diffs are not rendered by default.

Sources/SwiftSyntax/generated/syntaxNodes/SyntaxNodesGHI.swift

Lines changed: 176 additions & 176 deletions
Large diffs are not rendered by default.

Sources/SwiftSyntax/generated/syntaxNodes/SyntaxNodesJKLMN.swift

Lines changed: 205 additions & 205 deletions
Large diffs are not rendered by default.

Sources/SwiftSyntax/generated/syntaxNodes/SyntaxNodesOP.swift

Lines changed: 211 additions & 211 deletions
Large diffs are not rendered by default.

Sources/SwiftSyntax/generated/syntaxNodes/SyntaxNodesQRS.swift

Lines changed: 183 additions & 183 deletions
Large diffs are not rendered by default.

Sources/SwiftSyntax/generated/syntaxNodes/SyntaxNodesTUVWXYZ.swift

Lines changed: 188 additions & 188 deletions
Large diffs are not rendered by default.

0 commit comments

Comments
 (0)