Merge pull request #2120 from ahoppen/ahoppen/remove-parent-parameter

Remove the `parent` parameter from `SyntaxData.child(at:parent:)`

Author: ahoppen

CodeGeneration/Sources/generate-swift-syntax/templates/swiftsyntax/SyntaxNodesFile.swift

@@ -171,9 +171,9 @@ func syntaxNode(nodesStartingWith: [Character]) -> SourceFileSyntax {
           ) {
             AccessorDeclSyntax(accessorSpecifier: .keyword(.get)) {
               if child.isOptional {
-                StmtSyntax("return data.child(at: \(raw: index), parent: Syntax(self)).map(\(childType).init)")
+                StmtSyntax("return data.child(at: \(raw: index)).map(\(childType).init)")
               } else {
-                StmtSyntax("return \(childType)(data.child(at: \(raw: index), parent: Syntax(self))!)")
+                StmtSyntax("return \(childType)(data.child(at: \(raw: index))!)")
               }
             }
 

Sources/SwiftSyntax/SyntaxData.swift

@@ -292,10 +292,8 @@ struct SyntaxData {
   ///         data's layout.
   ///
   /// - Parameter index: The index to create and cache.
-  /// - Parameter parent: The parent to associate the child with. This is
-  ///             normally the Syntax node that this `SyntaxData` belongs to.
   /// - Returns: The child's data at the provided index.
-  func child(at index: Int, parent: Syntax) -> SyntaxData? {
+  func child(at index: Int) -> SyntaxData? {
     if raw.layoutView!.children[index] == nil { return nil }
     var iter = RawSyntaxChildren(absoluteRaw).makeIterator()
     for _ in 0..<index { _ = iter.next() }