Merge pull request #2342 from sophiapoirier/nonisolated-unsafe-experimental-feature-flag

guard nonisolated(unsafe) by experimental feature

Author: sophiapoirier

CodeGeneration/Sources/SyntaxSupport/ExperimentalFeatures.swift

@@ -18,6 +18,7 @@ public enum ExperimentalFeature: String, CaseIterable {
   case typedThrows
   case doExpressions
   case nonEscapableTypes
+  case globalConcurrency
 
   /// The name of the feature, which is used in the doc comment.
   public var featureName: String {
@@ -32,6 +33,8 @@ public enum ExperimentalFeature: String, CaseIterable {
       return "'do' expressions"
     case .nonEscapableTypes:
       return "NonEscableTypes"
+    case .globalConcurrency:
+      return "strict concurrency for globals"
     }
   }
 

Sources/SwiftParser/Modifiers.swift

@@ -61,7 +61,12 @@ extension Parser {
       case (.declarationModifier(.unowned), let handle)?:
         elements.append(self.parseUnownedModifier(handle))
       case (.declarationModifier(.nonisolated), let handle)?:
-        elements.append(parseNonisolatedModifier(handle))
+        if experimentalFeatures.contains(.globalConcurrency) {
+          elements.append(parseNonisolatedModifier(handle))
+        } else {
+          let (unexpectedBeforeKeyword, keyword) = self.eat(handle)
+          elements.append(RawDeclModifierSyntax(unexpectedBeforeKeyword, name: keyword, detail: nil, arena: self.arena))
+        }
       case (.declarationModifier(.final), let handle)?,
         (.declarationModifier(.required), let handle)?,
         (.declarationModifier(.optional), let handle)?,

Sources/SwiftParser/generated/ExperimentalFeatures.swift

@@ -38,4 +38,7 @@ extension Parser.ExperimentalFeatures {
 
   /// Whether to enable the parsing of NonEscableTypes.
   public static let nonEscapableTypes = Self (rawValue: 1 << 4)
+  
+  /// Whether to enable the parsing of strict concurrency for globals.
+  public static let globalConcurrency = Self (rawValue: 1 << 5)
 }

Tests/SwiftParserTest/DeclarationTests.swift

@@ -265,7 +265,8 @@ final class DeclarationTests: ParserTestCase {
           nonisolated(unsafe) var c: Int { 0 }
           nonisolated(unsafe) let d = 0
         }
-        """
+        """,
+      experimentalFeatures: [.globalConcurrency]
     )
   }