Skip to content

Commit 3386a27

Browse files
authored
Merge pull request #84 from edymtt/subprocess-text-streams-python3
[py3] Ensure we are using text streams
2 parents 1476e8a + bd2ee23 commit 3386a27

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

litTest

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,4 @@
33
set -ex
44

55
# Delegate to lit to actually test.
6-
python ../llvm-project/llvm/utils/lit/lit.py -sv "$@"
6+
python3 ../llvm-project/llvm/utils/lit/lit.py -sv "$@"

test-snapshot-binaries/linux_load_commands.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ def get_libraries(package_path):
143143
"-iname",
144144
"*.so"
145145
]
146-
return subprocess.check_output(cmd).split("\n")[:-1]
146+
return subprocess.check_output(cmd, universal_newlines=True).split("\n")[:-1]
147147

148148
def main():
149149
parser = argparse.ArgumentParser()

test-sourcekit-lsp/test-sourcekit-lsp.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@ def main():
136136
print('==== OUTPUT ====')
137137

138138
skargs = [args.sourcekit_lsp, '--sync', '-Xclangd', '-sync']
139-
p = subprocess.Popen(skargs, stdin=subprocess.PIPE, stdout=subprocess.PIPE)
139+
p = subprocess.Popen(skargs, stdin=subprocess.PIPE, stdout=subprocess.PIPE, universal_newlines=True)
140140
out, _ = p.communicate(lsp.script)
141141
print(out)
142142
print('')

0 commit comments

Comments
 (0)