(130669494) Only provide .busy file attribute when true (#759)

Author: jmschonfeld

Sources/FoundationEssentials/FileManager/FileManager+Utilities.swift

@@ -98,7 +98,11 @@ extension _FileManagerImpl {
                 attributes[.hfsCreatorCode] = _writeFileAttributePrimitive(kSymLinkCreator, as: UInt.self)
                 attributes[.hfsTypeCode] = _writeFileAttributePrimitive(kSymLinkFileType, as: UInt.self)
             }
-            attributes[.busy] = _writeFileAttributePrimitive((finderInfo.extendedFileInfo.extended_flags & 0x80 /*kExtendedFlagObjectIsBusy*/) != 0)
+            // To preserve historical behavior, only set this attribute if the value is true
+            let isBusy = (finderInfo.extendedFileInfo.extended_flags & 0x80 /*kExtendedFlagObjectIsBusy*/) != 0
+            if isBusy {
+                attributes[.busy] = _writeFileAttributePrimitive(true)
+            }
         }
         #endif
 

Tests/FoundationEssentialsTests/FileManager/FileManagerTests.swift

@@ -642,6 +642,8 @@ final class FileManagerTests : XCTestCase {
                 XCTAssertEqual(result[.immutable] as? Bool, test.immutable, "Item at path '\(test.path)' did not provide expected result for immutable key")
                 XCTAssertEqual(result[.appendOnly] as? Bool, test.appendOnly, "Item at path '\(test.path)' did not provide expected result for appendOnly key")
 
+                XCTAssertNil(result[.busy], "Item at path '\(test.path)' has non-nil value for .busy attribute") // Should only be set when true
+                
                 // Manually clean up attributes so removal does not fail
                 try $0.setAttributes([.immutable: false, .appendOnly: false], ofItemAtPath: test.path)
             }