Fix ProcessInfo.processName for Windows (#839)

iCharlesHu · web-flow · commit 0c124a94ed52 · 2024-08-09T12:48:41.000-07:00
Instead of relying on hard coding PATH_SEPARATOR, use existing .lastPathComponent that already works on Windows
diff --git a/Sources/FoundationEssentials/Platform.swift b/Sources/FoundationEssentials/Platform.swift
@@ -49,8 +49,6 @@ package struct Platform {
         _pageSize
     }
 
-    // FIXME: Windows SEPARATOR
-    static let PATH_SEPARATOR: Character = "/"
     static let MAX_HOSTNAME_LENGTH = 1024
 
     static func roundDownToMultipleOfPageSize(_ size: Int) -> Int {
diff --git a/Sources/FoundationEssentials/ProcessInfo/ProcessInfo.swift b/Sources/FoundationEssentials/ProcessInfo/ProcessInfo.swift
@@ -583,13 +583,7 @@ extension _ProcessInfo {
         guard let processPath = CommandLine.arguments.first else {
             return ""
         }
-
-        if let lastSlash = processPath.lastIndex(of: Platform.PATH_SEPARATOR) {
-            return String(processPath[
-                processPath.index(after: lastSlash) ..< processPath.endIndex])
-        }
-
-        return processPath
+        return processPath.lastPathComponent
     }
 
 #if os(macOS)

Original file line number	Diff line number	Diff line change
`@@ -49,8 +49,6 @@ package struct Platform {`
`49`	`49`	`_pageSize`
`50`	`50`	`}`
`51`	`51`
`52`		`- // FIXME: Windows SEPARATOR`
`53`		`- static let PATH_SEPARATOR: Character = "/"`
`54`	`52`	`static let MAX_HOSTNAME_LENGTH = 1024`
`55`	`53`
`56`	`54`	`static func roundDownToMultipleOfPageSize(_ size: Int) -> Int {`
Original file line number	Diff line number	Diff line change
`@@ -583,13 +583,7 @@ extension _ProcessInfo {`
`583`	`583`	`guard let processPath = CommandLine.arguments.first else {`
`584`	`584`	`return ""`
`585`	`585`	`}`
`586`		`-`
`587`		`- if let lastSlash = processPath.lastIndex(of: Platform.PATH_SEPARATOR) {`
`588`		`- return String(processPath[`
`589`		`- processPath.index(after: lastSlash) ..< processPath.endIndex])`
`590`		`- }`
`591`		`-`
`592`		`- return processPath`
	`586`	`+ return processPath.lastPathComponent`
`593`	`587`	`}`
`594`	`588`
`595`	`589`	`#if os(macOS)`