Skip to content

Commit 0a8c702

Browse files
committed
Remove default arguments from private functions
Since these are only ever called internally, these arguments should always be passed so it doesn't accidentally fall back to this file for expanding `#file` and friends.
1 parent 4e35114 commit 0a8c702

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

Sources/XCTest/Public/XCTAssert.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ private enum _XCTAssertionResult {
8383
}
8484
}
8585

86-
private func _XCTEvaluateAssertion(_ assertion: _XCTAssertion, message: @autoclosure () -> String = "", file: StaticString = #file, line: UInt = #line, expression: () throws -> _XCTAssertionResult) {
86+
private func _XCTEvaluateAssertion(_ assertion: _XCTAssertion, message: @autoclosure () -> String, file: StaticString, line: UInt, expression: () throws -> _XCTAssertionResult) {
8787
let result: _XCTAssertionResult
8888
do {
8989
result = try expression()
@@ -194,7 +194,7 @@ public func XCTAssertEqual<T: Numeric>(_ expression1: @autoclosure () throws ->
194194
_XCTAssertEqual(try expression1(), try expression2(), accuracy: accuracy, message(), file: file, line: line)
195195
}
196196

197-
private func _XCTAssertEqual<T: Numeric>(_ expression1: @autoclosure () throws -> T, _ expression2: @autoclosure () throws -> T, accuracy: T, _ message: @autoclosure () -> String = "", file: StaticString = #file, line: UInt = #line) {
197+
private func _XCTAssertEqual<T: Numeric>(_ expression1: @autoclosure () throws -> T, _ expression2: @autoclosure () throws -> T, accuracy: T, _ message: @autoclosure () -> String, file: StaticString, line: UInt) {
198198
_XCTEvaluateAssertion(.equalWithAccuracy, message: message(), file: file, line: line) {
199199
let (value1, value2) = (try expression1(), try expression2())
200200
if areEqual(value1, value2, accuracy: accuracy) {
@@ -323,7 +323,7 @@ public func XCTAssertNotEqual<T: Numeric>(_ expression1: @autoclosure () throws
323323
_XCTAssertNotEqual(try expression1(), try expression2(), accuracy: accuracy, message(), file: file, line: line)
324324
}
325325

326-
private func _XCTAssertNotEqual<T: Numeric>(_ expression1: @autoclosure () throws -> T, _ expression2: @autoclosure () throws -> T, accuracy: T, _ message: @autoclosure () -> String = "", file: StaticString = #file, line: UInt = #line) {
326+
private func _XCTAssertNotEqual<T: Numeric>(_ expression1: @autoclosure () throws -> T, _ expression2: @autoclosure () throws -> T, accuracy: T, _ message: @autoclosure () -> String, file: StaticString, line: UInt) {
327327
_XCTEvaluateAssertion(.notEqualWithAccuracy, message: message(), file: file, line: line) {
328328
let (value1, value2) = (try expression1(), try expression2())
329329
if !areEqual(value1, value2, accuracy: accuracy) {

0 commit comments

Comments
 (0)