TSD: correct FlsAlloc check

compnerd · compnerd · commit c7b03c4ae13d · 2019-03-06T08:40:29.000-08:00
FlsAlloc returns FLS_OUT_OF_INDEXES in an error scenario, everything
else is a valid result.  Correct the assertion.
diff --git a/src/shims/tsd.h b/src/shims/tsd.h
@@ -112,7 +112,8 @@ DISPATCH_TSD_INLINE
 static inline void
 _dispatch_thread_key_create(DWORD *k, void (DISPATCH_TSD_DTOR_CC *d)(void *))
 {
-	dispatch_assert_zero((*k = FlsAlloc(d)));
+	*k = FlsAlloc(d);
+	dispatch_assert(*k != FLS_OUT_OF_INDEXES);
 }
 
 extern DWORD __dispatch_tsd_key;

Original file line number	Diff line number	Diff line change
`@@ -112,7 +112,8 @@ DISPATCH_TSD_INLINE`
`112`	`112`	`static inline void`
`113`	`113`	`_dispatch_thread_key_create(DWORD k, void (DISPATCH_TSD_DTOR_CC d)(void *))`
`114`	`114`	`{`
`115`		`- dispatch_assert_zero((*k = FlsAlloc(d)));`
	`115`	`+ *k = FlsAlloc(d);`
	`116`	`+ dispatch_assert(*k != FLS_OUT_OF_INDEXES);`
`116`	`117`	`}`
`117`	`118`
`118`	`119`	`extern DWORD __dispatch_tsd_key;`