From b39cd038a0972b094cee798ae31d12fb9657044c Mon Sep 17 00:00:00 2001 From: Simon Evans Date: Mon, 15 Jun 2020 09:09:48 +0100 Subject: [PATCH] SR-9930: Re-enable assertion in TestProcess.test_passthrough_environment() - This test is believed to have broken due to thread issues when reading from stdout/stderr of the child process. - The threading issue was fixed in https://github.com/apple/swift-corelibs-foundation/pull/2523 --- Tests/Foundation/Tests/TestProcess.swift | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/Tests/Foundation/Tests/TestProcess.swift b/Tests/Foundation/Tests/TestProcess.swift index 3830c64006..679243be46 100644 --- a/Tests/Foundation/Tests/TestProcess.swift +++ b/Tests/Foundation/Tests/TestProcess.swift @@ -217,9 +217,7 @@ class TestProcess : XCTestCase { let env = try parseEnv(output) XCTAssertGreaterThan(env.count, 0) } catch { - // FIXME: SR-9930 parseEnv fails if an environment variable contains - // a newline. - // XCTFail("Test failed: \(error)") + XCTFail("Test failed: \(error)") } }