From facca683bbc273c306363e8f9073e4cc7371e9c2 Mon Sep 17 00:00:00 2001 From: Valeriy Van Date: Thu, 4 Jun 2020 11:38:54 +0200 Subject: [PATCH 1/2] Eliminates redundent array creation in convinience NSString.init() --- Sources/Foundation/NSString.swift | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Sources/Foundation/NSString.swift b/Sources/Foundation/NSString.swift index 5d3976c82b..47d7adbe88 100644 --- a/Sources/Foundation/NSString.swift +++ b/Sources/Foundation/NSString.swift @@ -231,8 +231,8 @@ open class NSString : NSObject, NSCopying, NSMutableCopying, NSSecureCoding, NSC } public override convenience init() { - let characters = Array(repeating: 0, count: 1) - self.init(characters: characters, length: 0) + var nul: unichar = 0 + self.init(characters: &nul, length: 0) } internal init(_ string: String) { From 9830e46935f6f3ef8dfc7d45bfab716368a05bcd Mon Sep 17 00:00:00 2001 From: Valeriy Van Date: Thu, 4 Jun 2020 15:51:24 +0200 Subject: [PATCH 2/2] Forwards initialization to NSString.init() --- Sources/Foundation/NSString.swift | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/Sources/Foundation/NSString.swift b/Sources/Foundation/NSString.swift index 47d7adbe88..11872e1593 100644 --- a/Sources/Foundation/NSString.swift +++ b/Sources/Foundation/NSString.swift @@ -231,8 +231,7 @@ open class NSString : NSObject, NSCopying, NSMutableCopying, NSSecureCoding, NSC } public override convenience init() { - var nul: unichar = 0 - self.init(characters: &nul, length: 0) + self.init("") } internal init(_ string: String) {