From 9079c94587b4b2ff1fc9dea8ebc3389525dc3c33 Mon Sep 17 00:00:00 2001 From: Sho Ikeda Date: Sun, 26 May 2019 20:38:37 +0900 Subject: [PATCH] Refactor `HTTPCookieStorage.sortedCookies` using the return value of `DispatchQueue.sync` --- Foundation/HTTPCookieStorage.swift | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/Foundation/HTTPCookieStorage.swift b/Foundation/HTTPCookieStorage.swift index b5330c966d..7434413c4c 100644 --- a/Foundation/HTTPCookieStorage.swift +++ b/Foundation/HTTPCookieStorage.swift @@ -337,12 +337,10 @@ open class HTTPCookieStorage: NSObject { @discussion proper sorting of cookies may require extensive string conversion, which can be avoided by allowing the system to perform the sorting. This API is to be preferred over the more generic -[HTTPCookieStorage cookies] API, if sorting is going to be performed. */ open func sortedCookies(using sortOrder: [NSSortDescriptor]) -> [HTTPCookie] { - var result: [HTTPCookie] = [] - syncQ.sync { + return syncQ.sync { let cookies = Array(allCookies.values) as NSArray - result = cookies.sortedArray(using: sortOrder) as! [HTTPCookie] + return cookies.sortedArray(using: sortOrder) as! [HTTPCookie] } - return result } }