From 186d942050c8e384cac1cd04e29c6d29c8991b0d Mon Sep 17 00:00:00 2001 From: Saleem Abdulrasool Date: Fri, 15 Feb 2019 10:07:01 -0800 Subject: [PATCH] Foundation: build CoreFoundation as /MD Use /MD and /MDd mode compilation rather than /MT or /MTd as per Microsoft's recommendation. This allows us to use a shared C runtime. The static MSVCRT/ucrt cannot be intermingled with a dynamic one. --- CMakeLists.txt | 3 --- 1 file changed, 3 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index e3613cc143..382df0c91e 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -36,9 +36,6 @@ ExternalProject_Add(CoreFoundation -DBUILD_SHARED_LIBS=NO -DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE} -DCMAKE_C_COMPILER=${CMAKE_C_COMPILER} - # NOTE(compnerd) ensure that we build it as a DLL as we - # wish to re-export the symbols from Foundation - -DCMAKE_C_FLAGS=-D_USRDLL -DCMAKE_MAKE_PROGRAM=${CMAKE_MAKE_PROGRAM} -DCMAKE_INSTALL_PREFIX= -DCMAKE_INSTALL_LIBDIR=usr/lib