Skip to content

Commit c408a9f

Browse files
committed
Addressed more review comments
1 parent a30b955 commit c408a9f

File tree

6 files changed

+16
-40
lines changed

6 files changed

+16
-40
lines changed

Sources/CoreFoundation/CMakeLists.txt

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -117,23 +117,9 @@ target_link_libraries(CoreFoundation
117117
_FoundationICU
118118
dispatch)
119119

120-
file(COPY
121-
"include/module.map"
122-
DESTINATION
123-
${CMAKE_BINARY_DIR}/CoreFoundationHeaders
124-
NO_SOURCE_PERMISSIONS)
125-
126-
127-
file(GLOB_RECURSE _CoreFoundationPublicHeaders "include/*.h")
128-
file(COPY
129-
${_CoreFoundationPublicHeaders}
130-
DESTINATION
131-
${CMAKE_BINARY_DIR}/CoreFoundationHeaders
132-
NO_SOURCE_PERMISSIONS)
133-
134120
set_property(GLOBAL APPEND PROPERTY Foundation_EXPORTS CoreFoundation)
135121

136122
install(DIRECTORY
137-
${CMAKE_BINARY_DIR}/CoreFoundationHeaders/
123+
include/
138124
DESTINATION
139125
lib/swift/CoreFoundation)

Sources/CoreFoundation/include/module.map

Lines changed: 0 additions & 4 deletions
This file was deleted.

Sources/Foundation/CMakeLists.txt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -157,9 +157,7 @@ target_link_libraries(Foundation
157157

158158
set_target_properties(Foundation PROPERTIES
159159
INSTALL_RPATH "$ORIGIN"
160-
BUILD_RPATH "$<TARGET_FILE_DIR:swiftDispatch>"
161-
Swift_MODULE_DIRECTORY ${CMAKE_BINARY_DIR}/swift
162-
INTERFACE_INCLUDE_DIRECTORIES ${CMAKE_BINARY_DIR}/swift)
160+
BUILD_RPATH "$<TARGET_FILE_DIR:swiftDispatch>")
163161

164162
target_link_libraries(Foundation PUBLIC
165163
swiftDispatch)

Sources/_CFURLSessionInterface/include/module.map

Lines changed: 0 additions & 3 deletions
This file was deleted.

Sources/_CFXMLInterface/include/module.map

Lines changed: 0 additions & 3 deletions
This file was deleted.

cmake/modules/FoundationSwiftSupport.cmake

Lines changed: 14 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,19 @@
1-
# Returns the os name in a variable
2-
#
3-
# Usage:
4-
# get_swift_host_os(result_var_name)
5-
#
6-
#
7-
# Sets ${result_var_name} with the converted OS name derived from
8-
# CMAKE_SYSTEM_NAME.
9-
function(get_swift_host_os result_var_name)
10-
set(${result_var_name} ${SWIFT_SYSTEM_NAME} PARENT_SCOPE)
11-
endfunction()
1+
##===----------------------------------------------------------------------===##
2+
##
3+
## This source file is part of the Swift open source project
4+
##
5+
## Copyright (c) 2024 Apple Inc. and the Swift project authors
6+
## Licensed under Apache License v2.0
7+
##
8+
## See LICENSE.txt for license information
9+
## See CONTRIBUTORS.md for the list of Swift project authors
10+
##
11+
## SPDX-License-Identifier: Apache-2.0
12+
##
13+
##===----------------------------------------------------------------------===##
1214

1315
function(_foundation_install_target module)
14-
get_swift_host_os(swift_os)
16+
set(swift_os ${SWIFT_SYSTEM_NAME})
1517
get_target_property(type ${module} TYPE)
1618

1719
if(type STREQUAL STATIC_LIBRARY)

0 commit comments

Comments
 (0)