FileManager: GetFileAttributesExW returns FALSE on failure

compnerd · compnerd · commit ad2cf4e3753c · 2019-03-12T13:51:49.000-07:00
As per the MSDN documentation, `GetFileAttributesExW` returns a non-zero
value on success.  Correct the boolean logic here.
diff --git a/Foundation/FileManager.swift b/Foundation/FileManager.swift
@@ -857,9 +857,9 @@ open class FileManager : NSObject {
       var faAttributes: WIN32_FILE_ATTRIBUTE_DATA = WIN32_FILE_ATTRIBUTE_DATA()
       return try path.withCString(encodedAs: UTF16.self) {
         if GetFileAttributesExW($0, GetFileExInfoStandard, &faAttributes) == FALSE {
-          return faAttributes
+          throw _NSErrorWithWindowsError(GetLastError(), reading: true)
         }
-        throw _NSErrorWithWindowsError(GetLastError(), reading: true)
+        return faAttributes
       }
     }
 #endif

Original file line number	Diff line number	Diff line change
`@@ -857,9 +857,9 @@ open class FileManager : NSObject {`
`857`	`857`	`var faAttributes: WIN32_FILE_ATTRIBUTE_DATA = WIN32_FILE_ATTRIBUTE_DATA()`
`858`	`858`	`return try path.withCString(encodedAs: UTF16.self) {`
`859`	`859`	`if GetFileAttributesExW($0, GetFileExInfoStandard, &faAttributes) == FALSE {`
`860`		`- return faAttributes`
	`860`	`+ throw _NSErrorWithWindowsError(GetLastError(), reading: true)`
`861`	`861`	`}`
`862`		`- throw _NSErrorWithWindowsError(GetLastError(), reading: true)`
	`862`	`+ return faAttributes`
`863`	`863`	`}`
`864`	`864`	`}`
`865`	`865`	`#endif`