Merge pull request #1867 from YOCKOW/sr-9758

Author: swift-ci

Foundation/XMLParser.swift

@@ -465,16 +465,14 @@ open class XMLParser : NSObject {
     }
 
     internal func _handleParseResult(_ parseResult: Int32) -> Bool {
-        return true
-        /*
-        var result = true
-        if parseResult != 0 {
-            if parseResult != -1 {
-                // TODO: determine if this result is a fatal error from libxml via the CF implementations
+        if parseResult == 0 {
+            return true
+        } else {
+            if _parserError == nil {
+                _parserError = NSError(domain: XMLParser.errorDomain, code: Int(parseResult))
             }
         }
-        return result
-        */
+        return false
     }
 
     internal func parseData(_ data: Data) -> Bool {

TestFoundation/TestXMLParser.swift

@@ -65,6 +65,7 @@ class TestXMLParser : XCTestCase {
             ("test_withData", test_withData),
             ("test_withDataEncodings", test_withDataEncodings),
             ("test_withDataOptions", test_withDataOptions),
+            ("test_sr9758_abortParsing", test_sr9758_abortParsing),
         ]
     }
 
@@ -141,4 +142,16 @@ class TestXMLParser : XCTestCase {
         XCTAssertTrue(res)
     }
 
+    func test_sr9758_abortParsing() {
+        class Delegate: NSObject, XMLParserDelegate {
+            func parserDidStartDocument(_ parser: XMLParser) { parser.abortParsing() }
+        }
+        let xml = TestXMLParser.xmlUnderTest(encoding: .utf8)
+        let parser = XMLParser(data: xml.data(using: .utf8)!)
+        let delegate = Delegate()
+        parser.delegate = delegate
+        XCTAssertFalse(parser.parse())
+        XCTAssertNotNil(parser.parserError)
+    }
+
 }