Merge pull request #2306 from ikesyo/refactor-loadPersistedCookies

Pushkar N Kulkarni · web-flow · commit 712e7b7af40d · 2019-05-27T11:57:15.000+05:30
Refactor `HTTPCookieStorage.loadPersistedCookies`
diff --git a/Foundation/HTTPCookieStorage.swift b/Foundation/HTTPCookieStorage.swift
@@ -91,8 +91,8 @@ open class HTTPCookieStorage: NSObject {
         guard let cookies = try? PropertyListSerialization.propertyList(from: cookiesData, format: nil) else { return }
         let cookies0 = cookies as? [String: [String: Any]] ?? [:]
         self.syncQ.sync {
-            for key in cookies0.keys {
-                if let cookie = createCookie(cookies0[key]!) {
+            for (key, value) in cookies0 {
+                if let cookie = createCookie(value) {
                     allCookies[key] = cookie
                 }
             }

Original file line number	Diff line number	Diff line change
`@@ -91,8 +91,8 @@ open class HTTPCookieStorage: NSObject {`
`91`	`91`	`guard let cookies = try? PropertyListSerialization.propertyList(from: cookiesData, format: nil) else { return }`
`92`	`92`	`let cookies0 = cookies as? [String: [String: Any]] ?? [:]`
`93`	`93`	`self.syncQ.sync {`
`94`		`- for key in cookies0.keys {`
`95`		`- if let cookie = createCookie(cookies0[key]!) {`
	`94`	`+ for (key, value) in cookies0 {`
	`95`	`+ if let cookie = createCookie(value) {`
`96`	`96`	`allCookies[key] = cookie`
`97`	`97`	`}`
`98`	`98`	`}`