CFLocale: correct an invalid check for CFRelease (#1611)

compnerd · parkera · commit 627d7d8e61e1 · 2018-06-19T09:24:17.000-07:00
Found by inspection.
diff --git a/CoreFoundation/Locale.subproj/CFCalendar.c b/CoreFoundation/Locale.subproj/CFCalendar.c
@@ -48,7 +48,7 @@ static void __CFCalendarDeallocate(CFTypeRef cf) {
     if (calendar->_identifier) CFRelease(calendar->_identifier);
     if (calendar->_locale) CFRelease(calendar->_locale);
     if (calendar->_localeID) CFRelease(calendar->_localeID);
-    if (calendar->_identifier) CFRelease(calendar->_tz);
+    if (calendar->_tz) CFRelease(calendar->_tz);
     if (calendar->_cal) ucal_close(calendar->_cal);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ static void __CFCalendarDeallocate(CFTypeRef cf) {`
`48`	`48`	`if (calendar->_identifier) CFRelease(calendar->_identifier);`
`49`	`49`	`if (calendar->_locale) CFRelease(calendar->_locale);`
`50`	`50`	`if (calendar->_localeID) CFRelease(calendar->_localeID);`
`51`		`- if (calendar->_identifier) CFRelease(calendar->_tz);`
	`51`	`+ if (calendar->_tz) CFRelease(calendar->_tz);`
`52`	`52`	`if (calendar->_cal) ucal_close(calendar->_cal);`
`53`	`53`	`}`
`54`	`54`