Skip to content

Commit 781d69f

Browse files
authored
ToolchainRegistryTests: don't do identity check for localFileSystem (#733)
We'd like to remove `AnyObject` requirement from `FileSystem`, which will make identity checks on `any FileSystem` impossible. These checks were an anti-pattern anyway, especially in tests, which should be flexible enough to support an arbitrary file system implementation. If certain behavior is not available on `FileSystem` we should modify that protocol instead.
1 parent af6309e commit 781d69f

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Tests/SKCoreTests/ToolchainRegistryTests.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -520,7 +520,7 @@ private func makeToolchain(
520520
sourcekitdInProc: Bool = false,
521521
libIndexStore: Bool = false
522522
) {
523-
precondition(!clang && !swiftc && !clangd || fs === localFileSystem || !shouldChmod,
523+
precondition(!clang && !swiftc && !clangd || !shouldChmod,
524524
"Cannot make toolchain binaries exectuable with InMemoryFileSystem")
525525

526526
// tiny PE binary from: https://archive.is/w01DO

0 commit comments

Comments
 (0)