Skip to content

Added example #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2019
Merged

Added example #18

merged 1 commit into from
Oct 21, 2019

Conversation

lewislbr
Copy link

Hi there,

First of all, thanks for this great work, it's exactly what I was looking for!

I've added an example adapted from a recent implementation I did of this package with React Router, I thought I could share it so it may help somebody. I've moved the existing example and this one into a new examples folder.

If anything can be improved please let me know.

Cheers!

@swyxio
Copy link
Contributor

swyxio commented Oct 21, 2019

thanks v much! can you tweak the readme to make it obvious the differences between the examples? as a rule you want to spell it out for the next user who comes along. also instead of naming folders "example1" "example2", name them something a little more obvious. make a call on what that is but you can do better than 1 and 2

@lewislbr
Copy link
Author

Sure! Please check the changes and let me know what you think

@swyxio
Copy link
Contributor

swyxio commented Oct 21, 2019

excellent :) thank you very much

@swyxio swyxio merged commit e67e93b into netlify-labs:master Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants