Skip to content

Commit cf2f258

Browse files
author
jim
committed
revert 1602523, until there is understanding
about what the actual issue and "requirement" are. git-svn-id: http://svn.apache.org/repos/asf/httpd/httpd/trunk@1602697 13f79535-47bb-0310-9956-ffa450edef68
1 parent f178e28 commit cf2f258

File tree

2 files changed

+10
-16
lines changed

2 files changed

+10
-16
lines changed

modules/proxy/mod_proxy.c

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1045,11 +1045,6 @@ static int proxy_handler(request_rec *r)
10451045
}
10461046

10471047
scheme = apr_pstrndup(r->pool, uri, p - uri);
1048-
1049-
if (strcmp(scheme, "auto") == 0) {
1050-
apr_table_set(r->notes, "auto", uri);
1051-
uri = apr_pstrcat(r->pool, ap_http_scheme(r), p, NULL);
1052-
}
10531048
/* Check URI's destination host against NoProxy hosts */
10541049
/* Bypass ProxyRemote server lookup if configured as NoProxy */
10551050
for (direct_connect = i = 0; i < conf->dirconn->nelts &&
@@ -1156,8 +1151,8 @@ static int proxy_handler(request_rec *r)
11561151

11571152
/* handle the scheme */
11581153
ap_log_rerror(APLOG_MARK, APLOG_DEBUG, 0, r, APLOGNO(01143)
1159-
"Running scheme %s handler for %s (attempt %d)",
1160-
scheme, url, attempts);
1154+
"Running scheme %s handler (attempt %d)",
1155+
scheme, attempts);
11611156
AP_PROXY_RUN(r, worker, conf, url, attempts);
11621157
access_status = proxy_run_scheme_handler(r, worker, conf,
11631158
url, NULL, 0);
@@ -1484,15 +1479,15 @@ static const char *
14841479

14851480
static char *de_socketfy(apr_pool_t *p, char *url)
14861481
{
1487-
char *ptr, *ret = url;
1482+
char *ptr;
14881483
/*
14891484
* We could be passed a URL during the config stage that contains
14901485
* the UDS path... ignore it
14911486
*/
14921487
if (!strncasecmp(url, "unix:", 5) &&
14931488
((ptr = ap_strchr(url, '|')) != NULL)) {
14941489
/* move past the 'unix:...|' UDS path info */
1495-
char *c;
1490+
char *ret, *c;
14961491

14971492
ret = ptr + 1;
14981493
/* special case: "unix:....|scheme:" is OK, expand
@@ -1503,10 +1498,13 @@ static char *de_socketfy(apr_pool_t *p, char *url)
15031498
return NULL;
15041499
}
15051500
if (c[1] == '\0') {
1506-
ret = apr_pstrcat(p, ret, "//localhost", NULL);
1501+
return apr_pstrcat(p, ret, "//localhost", NULL);
1502+
}
1503+
else {
1504+
return ret;
15071505
}
15081506
}
1509-
return ret;
1507+
return url;
15101508
}
15111509

15121510
static const char *

modules/proxy/proxy_util.c

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1907,11 +1907,7 @@ PROXY_DECLARE(int) ap_proxy_pre_request(proxy_worker **worker,
19071907

19081908
access_status = proxy_run_pre_request(worker, balancer, r, conf, url);
19091909
if (access_status == DECLINED && *balancer == NULL) {
1910-
const char *murl;
1911-
if ((murl = apr_table_get(r->notes, "auto")) == NULL) {
1912-
murl = *url;
1913-
}
1914-
*worker = ap_proxy_get_worker(r->pool, NULL, conf, murl);
1910+
*worker = ap_proxy_get_worker(r->pool, NULL, conf, *url);
19151911
if (*worker) {
19161912
ap_log_rerror(APLOG_MARK, APLOG_TRACE2, 0, r,
19171913
"%s: found worker %s for %s",

0 commit comments

Comments
 (0)