fix: update generated ssr.noExternal config to always include all svelte dependencies to avoid failed svelte deduplication during dev with vite-3

Author: dominikg

packages/e2e-tests/kit-node/package.json

@@ -14,8 +14,8 @@
   "devDependencies": {
     "@sveltejs/adapter-node": "^1.0.0-next.79",
     "@sveltejs/kit": "^1.0.0-next.370",
-    "e2e-test-dep-svelte-api-only": "workspace:*",
-    "e2e-test-dep-vite-plugins": "workspace:*",
+    "e2e-test-dep-svelte-api-only": "file:../_test_dependencies/svelte-api-only",
+    "e2e-test-dep-vite-plugins": "file:../_test_dependencies/vite-plugins",
     "svelte": "^3.49.0",
     "svelte-check": "^2.8.0",
     "svelte-i18n": "^3.4.0",

packages/e2e-tests/kit-node/vite.config.js

@@ -12,10 +12,6 @@ const config = {
 			interval: 100
 		}
 	},
-	ssr: {
-		// TODO this is needed otherwise tests fail. investigate
-		noExternal: ['e2e-test-dep-svelte-api-only']
-	},
 	plugins: [transformValidation(), sveltekit()]
 };
 

packages/vite-plugin-svelte/src/utils/options.ts

@@ -407,23 +407,15 @@ function buildSSROptionsForSvelte(
 
 	// add svelte to ssr.noExternal unless it is present in ssr.external
 	// so we can resolve it with svelte/ssr
-	if (options.isBuild && config.build?.ssr) {
-		if (!config.ssr?.external?.includes('svelte')) {
-			noExternal.push('svelte', /^svelte\//);
-		}
-	} else {
-		// for non-ssr build, we exclude svelte js library deps to make development faster
-		// and also because vite doesn't handle them properly.
-		// see https://github.com/sveltejs/vite-plugin-svelte/issues/168
-		// see https://github.com/vitejs/vite/issues/2579
-		svelteDeps = svelteDeps.filter((dep) => dep.type === 'component-library');
+	if (!config.ssr?.external?.includes('svelte')) {
+		noExternal.push('svelte', /^svelte\//);
 	}
 
-	// add svelte dependencies to ssr.noExternal unless present in ssr.external or optimizeDeps.include
+	// add svelte dependencies to ssr.noExternal unless present in ssr.external
 	noExternal.push(
-		...Array.from(new Set(svelteDeps.map((s) => s.name))).filter((x) => {
-			return !config.ssr?.external?.includes(x) && !config.optimizeDeps?.include?.includes(x);
-		})
+		...Array.from(new Set(svelteDeps.map((s) => s.name))).filter(
+			(x) => !config.ssr?.external?.includes(x)
+		)
 	);
 	const ssr = {
 		noExternal,