Merge pull request #828 from jpsc/master

Rich-Harris · web-flow · commit 7d774223fc89 · 2017-09-07T17:30:52.000-04:00
feat(a11y): add warning missing lang on html tag
diff --git a/src/validate/html/a11y.ts b/src/validate/html/a11y.ts
@@ -143,6 +143,11 @@ export default function a11y(
 		shouldHaveAttribute(['title']);
 	}
 
+	// html-has-lang
+	if (node.name === 'html') {
+		shouldHaveAttribute(['lang']);
+	}
+
 	// no-distracting-elements
 	if (node.name === 'marquee' || node.name === 'blink') {
 		validator.warn(`A11y: Avoid <${node.name}> elements`, node.start);
@@ -168,4 +173,4 @@ function getValue(attribute: Node) {
 	if (attribute.value.length === 1 && attribute.value[0].type === 'Text') return attribute.value[0].data;
 
 	return null;
-}
+}
diff --git a/test/validator/samples/a11y-html-has-lang/input.html b/test/validator/samples/a11y-html-has-lang/input.html
@@ -0,0 +1,5 @@
+<html lang="en"></html>
+<html lang="en-US"></html>
+<html lang={{language}}></html>
+
+<html></html>
diff --git a/test/validator/samples/a11y-html-has-lang/warnings.json b/test/validator/samples/a11y-html-has-lang/warnings.json
@@ -0,0 +1,10 @@
+[
+		{
+			"loc": {
+				"column": 0,
+				"line": 5
+			},
+			"message": "A11y: <html> element should have a lang attribute",
+			"pos": 82
+		}
+	]
