Skip to content

Commit 5c70456

Browse files
authored
Merge pull request #2090 from sveltejs/gh-2078
fix two examples
2 parents fa1322b + 1939b86 commit 5c70456

File tree

2 files changed

+20
-23
lines changed

2 files changed

+20
-23
lines changed

site/content/examples/7guis-crud/App.svelte

Lines changed: 13 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,22 @@
33
<script>
44
export let people = [];
55
6-
let filteredPeople;
7-
let selected;
86
let prefix = '';
97
let first = '';
108
let last = '';
119
let i = 0;
1210
11+
$: filteredPeople = prefix
12+
? people.filter(person => {
13+
const name = `${person.last}, ${person.first}`;
14+
return name.toLowerCase().startsWith(prefix.toLowerCase());
15+
})
16+
: people;
17+
18+
$: selected = filteredPeople[i];
19+
20+
$: reset_inputs(selected);
21+
1322
function create() {
1423
people = people.concat({ first, last });
1524
i = people.length - 1;
@@ -27,18 +36,8 @@
2736
i = Math.min(i, people.length - 1);
2837
}
2938
30-
$: filteredPeople = prefix
31-
? people.filter(person => {
32-
const name = `${person.last}, ${person.first}`;
33-
return name.toLowerCase().startsWith(prefix.toLowerCase());
34-
})
35-
: people;
36-
37-
$: selected = filteredPeople[i];
38-
39-
$: if (selected) {
40-
first = selected.first;
41-
last = selected.last;
39+
function reset_inputs(person) {
40+
({ first, last } = person);
4241
}
4342
</script>
4443

site/content/examples/7guis-flight-booker/App.svelte

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,26 +1,24 @@
11
<script>
22
const tomorrow = new Date(Date.now() + 86400000);
33
4-
const tomorrowAsString = [
4+
let start = [
55
tomorrow.getFullYear(),
66
pad(tomorrow.getMonth() + 1, 2),
77
pad(tomorrow.getDate(), 2)
88
].join('-');
99
10-
let start = tomorrowAsString;
11-
let end = tomorrowAsString;
10+
let end = start;
1211
let isReturn = false;
1312
14-
const startDate = () => convertToDate(start);
15-
const endDate = () => convertToDate(end);
16-
13+
$: startDate = convertToDate(start);
14+
$: endDate = convertToDate(end);
1715
1816
function bookFlight() {
1917
const type = isReturn ? 'return' : 'one-way';
2018
21-
let message = `You have booked a ${type} flight, leaving ${startDate().toDateString()}`;
19+
let message = `You have booked a ${type} flight, leaving ${startDate.toDateString()}`;
2220
if (type === 'return') {
23-
message += ` and returning ${endDate().toDateString()}`;
21+
message += ` and returning ${endDate.toDateString()}`;
2422
}
2523
2624
alert(message);
@@ -57,5 +55,5 @@
5755

5856
<button
5957
on:click={bookFlight}
60-
disabled="{isReturn && (startDate() >= endDate())}"
58+
disabled="{isReturn && (startDate >= endDate)}"
6159
>book</button>

0 commit comments

Comments
 (0)