Skip to content

Commit 49b97ae

Browse files
committed
chore: revert test.ts changes and move test to validator
1 parent 577502b commit 49b97ae

File tree

4 files changed

+24
-34
lines changed

4 files changed

+24
-34
lines changed

packages/svelte/tests/compiler-errors/samples/attribute-unique-allowed/_config.js

Lines changed: 0 additions & 5 deletions
This file was deleted.

packages/svelte/tests/compiler-errors/test.ts

Lines changed: 23 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,11 @@ import { suite, type BaseTest } from '../suite';
55
import { read_file } from '../helpers.js';
66

77
interface CompilerErrorTest extends BaseTest {
8-
error:
9-
| {
10-
code: string;
11-
message: string;
12-
position?: [number, number];
13-
}
14-
| false;
8+
error: {
9+
code: string;
10+
message: string;
11+
position?: [number, number];
12+
};
1513
}
1614

1715
const { test, run } = suite<CompilerErrorTest>((config, cwd) => {
@@ -20,56 +18,52 @@ const { test, run } = suite<CompilerErrorTest>((config, cwd) => {
2018
}
2119

2220
if (fs.existsSync(`${cwd}/main.svelte`)) {
23-
let caught_error: CompileError | null = null;
21+
let caught_error = false;
2422

2523
try {
2624
compile(read_file(`${cwd}/main.svelte`), {
2725
generate: 'client'
2826
});
2927
} catch (e) {
30-
caught_error = e as CompileError;
28+
const error = e as CompileError;
3129

32-
if (config.error) {
33-
expect(caught_error.code).toBe(config.error.code);
34-
expect(caught_error.message).toBe(config.error.message);
30+
caught_error = true;
3531

36-
if (config.error.position) {
37-
expect(caught_error.position).toEqual(config.error.position);
38-
}
32+
expect(error.code).toBe(config.error.code);
33+
expect(error.message).toBe(config.error.message);
34+
35+
if (config.error.position) {
36+
expect(error.position).toEqual(config.error.position);
3937
}
4038
}
4139

42-
if (config.error && caught_error == null) {
40+
if (!caught_error) {
4341
assert.fail('Expected an error');
44-
} else if (!config.error && caught_error != null) {
45-
assert.fail(`Unexpected error: ${caught_error.code}`);
4642
}
4743
}
4844

4945
if (fs.existsSync(`${cwd}/main.svelte.js`)) {
50-
let caught_error: CompileError | null = null;
46+
let caught_error = false;
5147

5248
try {
5349
compileModule(read_file(`${cwd}/main.svelte.js`), {
5450
generate: 'client'
5551
});
5652
} catch (e) {
57-
caught_error = e as CompileError;
53+
const error = e as CompileError;
54+
55+
caught_error = true;
5856

59-
if (config.error) {
60-
expect(caught_error.code).toEqual(config.error.code);
61-
expect(caught_error.message).toEqual(config.error.message);
57+
expect(error.code).toEqual(config.error.code);
58+
expect(error.message).toEqual(config.error.message);
6259

63-
if (config.error.position) {
64-
expect(caught_error.position).toEqual(config.error.position);
65-
}
60+
if (config.error.position) {
61+
expect(error.position).toEqual(config.error.position);
6662
}
6763
}
6864

69-
if (config.error && caught_error == null) {
65+
if (!caught_error) {
7066
assert.fail('Expected an error');
71-
} else if (!config.error && caught_error != null) {
72-
assert.fail(`Unexpected error: ${caught_error.code}`);
7367
}
7468
}
7569
});
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
[]

0 commit comments

Comments
 (0)