From 7f646d5f8188d218c0591c9b1dc8ad62cd937e5c Mon Sep 17 00:00:00 2001 From: yosuke ota Date: Fri, 13 Sep 2024 12:43:07 +0900 Subject: [PATCH 1/2] fix: incorrect runes inference when having empty compiler options --- src/svelte-config/parser.ts | 4 ++-- tests/src/svelte-config/parser.ts | 6 ++++++ 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src/svelte-config/parser.ts b/src/svelte-config/parser.ts index 451072d1..f4adc5e1 100644 --- a/src/svelte-config/parser.ts +++ b/src/svelte-config/parser.ts @@ -62,7 +62,7 @@ function parseSvelteConfigExpression( if (compilerOptions?.type === EvaluatedType.object) { result.compilerOptions = {}; const runes = compilerOptions.getProperty("runes")?.getStatic(); - if (runes) { + if (runes?.value != null) { result.compilerOptions.runes = Boolean(runes.value); } } @@ -70,7 +70,7 @@ function parseSvelteConfigExpression( if (kit?.type === EvaluatedType.object) { result.kit = {}; const files = kit.getProperty("files")?.getStatic(); - if (files) result.kit.files = files.value as never; + if (files?.value != null) result.kit.files = files.value as never; } return result; } diff --git a/tests/src/svelte-config/parser.ts b/tests/src/svelte-config/parser.ts index 7f97721d..2bc3a199 100644 --- a/tests/src/svelte-config/parser.ts +++ b/tests/src/svelte-config/parser.ts @@ -60,6 +60,12 @@ describe("parseConfig", () => { `, output: { compilerOptions: { runes: true } }, }, + { + code: ` + export default {compilerOptions:{}} + `, + output: { compilerOptions: {} }, + }, ]; for (const { code, output } of testCases) { it(code, () => { From d01c1d95341c23f52437230c0dc01da5136fdb46 Mon Sep 17 00:00:00 2001 From: Yosuke Ota Date: Fri, 13 Sep 2024 12:44:23 +0900 Subject: [PATCH 2/2] Create late-poems-collect.md --- .changeset/late-poems-collect.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/late-poems-collect.md diff --git a/.changeset/late-poems-collect.md b/.changeset/late-poems-collect.md new file mode 100644 index 00000000..2934814f --- /dev/null +++ b/.changeset/late-poems-collect.md @@ -0,0 +1,5 @@ +--- +"svelte-eslint-parser": patch +--- + +fix: incorrect runes inference when having empty compiler options