Skip to content

False positive unused import when using stores only in reactive statements #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
KentoNishi opened this issue Oct 4, 2021 · 2 comments · Fixed by #89
Closed

False positive unused import when using stores only in reactive statements #88

KentoNishi opened this issue Oct 4, 2021 · 2 comments · Fixed by #89
Labels
bug Something isn't working

Comments

@KentoNishi
Copy link

image

The savingStatus store is only used in this one line that starts with $:, and the parser incorrectly marks it as an unused import. Removing the reactive statement and converting it into a function fixes it, but it's not very elegant. I'd love it if the parser could ignore the reactive $: statement when determining unused imports!

image

@KentoNishi KentoNishi changed the title False positive when using stores only in reactive statements False positive unused import when using stores only in reactive statements Oct 4, 2021
@ota-meshi ota-meshi added the bug Something isn't working label Oct 4, 2021
@KentoNishi
Copy link
Author

@ota-meshi レスポンス早くてびっくりしました!わざわざお忙しい中ありがとうございます🙇‍♂️

@ota-meshi
Copy link
Member

バグ報告ありがとうございます。そちらもでうまく動くといいのですが😅
また何かあればissueください🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants