Skip to content

Commit 2437a81

Browse files
ota-meshiota-meshi
authored
fix: CI error with svelte v4-next.1 (#349)
* fix: CI error with svelte v4.next.1 * format
1 parent b8435a1 commit 2437a81

8 files changed

+44
-44
lines changed

‎package.json

+35-36
Original file line numberDiff line numberDiff line change
@@ -58,54 +58,53 @@
5858
"espree": "^9.0.0"
5959
},
6060
"devDependencies": {
61-
"@changesets/changelog-github": "^0.4.6",
62-
"@changesets/cli": "^2.24.2",
63-
"@changesets/get-release-plan": "^3.0.0",
64-
"@ota-meshi/eslint-plugin": "^0.13.0",
65-
"@types/benchmark": "^2.1.1",
66-
"@types/chai": "^4.3.0",
67-
"@types/eslint": "^8.0.0",
68-
"@types/eslint-scope": "^3.7.0",
61+
"@changesets/changelog-github": "^0.4.8",
62+
"@changesets/cli": "^2.26.1",
63+
"@changesets/get-release-plan": "^3.0.16",
64+
"@ota-meshi/eslint-plugin": "^0.13.7",
65+
"@types/benchmark": "^2.1.2",
66+
"@types/chai": "^4.3.5",
67+
"@types/eslint": "^8.40.1",
68+
"@types/eslint-scope": "^3.7.4",
6969
"@types/eslint-visitor-keys": "^1.0.0",
70-
"@types/estree": "^1.0.0",
71-
"@types/mocha": "^10.0.0",
72-
"@types/node": "^18.11.0",
73-
"@types/semver": "^7.3.9",
74-
"@typescript-eslint/eslint-plugin": "^5.4.0",
75-
"@typescript-eslint/parser": "~5.59.0",
76-
"@typescript-eslint/types": "^5.59.5",
70+
"@types/estree": "^1.0.1",
71+
"@types/mocha": "^10.0.1",
72+
"@types/node": "^18.16.16",
73+
"@types/semver": "^7.5.0",
74+
"@typescript-eslint/eslint-plugin": "^5.59.9",
75+
"@typescript-eslint/parser": "~5.59.9",
76+
"@typescript-eslint/types": "^5.59.9",
7777
"benchmark": "^2.1.4",
78-
"chai": "^4.3.4",
78+
"chai": "^4.3.7",
7979
"env-cmd": "^10.1.0",
80-
"esbuild": "^0.17.0",
81-
"esbuild-register": "^3.3.3",
82-
"eslint": "^8.2.0",
80+
"esbuild": "^0.17.19",
81+
"esbuild-register": "^3.4.2",
82+
"eslint": "^8.42.0",
8383
"eslint-config-prettier": "^8.8.0",
8484
"eslint-plugin-eslint-comments": "^3.2.0",
85-
"eslint-plugin-json-schema-validator": "^4.0.0",
86-
"eslint-plugin-jsonc": "^2.0.0",
85+
"eslint-plugin-json-schema-validator": "^4.5.0",
86+
"eslint-plugin-jsonc": "^2.8.0",
8787
"eslint-plugin-node": "^11.1.0",
8888
"eslint-plugin-node-dependencies": "^0.11.0",
89-
"eslint-plugin-prettier": "^4.0.0",
90-
"eslint-plugin-regexp": "^1.5.0",
91-
"eslint-plugin-svelte": "^2.28.0",
92-
"eslint-plugin-yml": "^1.0.0",
93-
"estree-walker": "^3.0.0",
89+
"eslint-plugin-prettier": "^4.2.1",
90+
"eslint-plugin-regexp": "^1.15.0",
91+
"eslint-plugin-svelte": "^2.30.0",
92+
"eslint-plugin-yml": "^1.7.0",
93+
"estree-walker": "^3.0.3",
9494
"locate-character": "^2.0.5",
9595
"magic-string": "^0.30.0",
96-
"mocha": "^10.0.0",
97-
"mocha-chai-jest-snapshot": "^1.1.3",
96+
"mocha": "^10.2.0",
97+
"mocha-chai-jest-snapshot": "^1.1.4",
9898
"nyc": "^15.1.0",
99-
"prettier": "^2.8.0",
100-
"prettier-plugin-pkg": "^0.17.0",
99+
"prettier": "^2.8.8",
100+
"prettier-plugin-pkg": "^0.17.1",
101101
"prettier-plugin-svelte": "^2.10.1",
102-
"rimraf": "^5.0.0",
103-
"semver": "^7.3.5",
104-
"svelte": "^4.0.0-0",
102+
"rimraf": "^5.0.1",
103+
"semver": "^7.5.1",
104+
"svelte": "^4.0.0-next.1",
105105
"svelte2tsx": "^0.6.15",
106-
"typescript": "~5.1.0",
107-
"typescript-eslint-parser-for-extra-files": "^0.5.0",
108-
"vue-eslint-parser": "^9.0.0"
106+
"typescript": "~5.1.3",
107+
"typescript-eslint-parser-for-extra-files": "^0.5.0"
109108
},
110109
"publishConfig": {
111110
"access": "public"

‎src/parser/template.ts

+1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import type {} from "svelte"; // FIXME: Workaround to get type information for "svelte/compiler"
12
import { parse } from "svelte/compiler";
23
import type * as SvAST from "./svelte-ast-types";
34
import type { Context } from "../context";

‎tests/fixtures/parser/ast/ts-event02-type-output.svelte

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<script lang="typescript">
2-
import Component from 'foo.svelte' // Component: typeof SvelteComponentDev
2+
import Component from 'foo.svelte' // Component: any
33
</script>
44
<button on:click="{e=>{}}"></button> <!-- e: MouseEvent & { currentTarget: EventTarget & HTMLButtonElement; } -->
5-
<Component on:click="{e=>{}}"></Component> <!-- Component: typeof SvelteComponentDev, e: CustomEvent<any> -->
5+
<Component on:click="{e=>{}}"></Component> <!-- Component: any, e: any -->

‎tests/fixtures/parser/ast/ts-event05-type-output.svelte

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
<script lang="ts">
2-
import Component from './ts-event03-input.svelte'; // Component: typeof SvelteComponentDev
2+
import Component from './ts-event03-input.svelte'; // Component: any
33
</script>
44

5-
<Component on:foo="{e=>{ // Component: typeof SvelteComponentDev, e: CustomEvent<any>
5+
<Component on:foo="{e=>{ // Component: any, e: any
66
// e.detail is number
77
// `@typescript-eslint/parser` doesn't get the correct types.
88
// Using `typescript-eslint-parser-for-extra-files` will give we the correct types.

‎tests/fixtures/parser/ast/ts-reactive02-type-output.svelte

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<script lang="ts">
2-
import { writable } from 'svelte/store'; // writable: <T>(value: T, start?: StartStopNotifier<T> | undefined) => Writable<T>, writable: <T>(value: T, start?: StartStopNotifier<T> | undefined) => Writable<T>
2+
import { writable } from 'svelte/store'; // writable: <T_1>(value?: T_1 | undefined, start?: StartStopNotifier<T_1> | undefined) => Writable<T_1>, writable: <T_1>(value?: T_1 | undefined, start?: StartStopNotifier<T_1> | undefined) => Writable<T_1>
33
let x = "hello" // x: string
44
const get = ()=>"hello" // get: () => string
55

‎tests/fixtures/parser/ast/ts-reactive05-type-output.svelte

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<script lang="ts">
2-
import { writable } from 'svelte/store'; // writable: <T>(value: T, start?: StartStopNotifier<T> | undefined) => Writable<T>, writable: <T>(value: T, start?: StartStopNotifier<T> | undefined) => Writable<T>
2+
import { writable } from 'svelte/store'; // writable: <T_1>(value?: T_1 | undefined, start?: StartStopNotifier<T_1> | undefined) => Writable<T_1>, writable: <T_1>(value?: T_1 | undefined, start?: StartStopNotifier<T_1> | undefined) => Writable<T_1>
33
44
const a = writable(0) // a: Writable<number>, writable(0): Writable<number>
55
$: aValue = $a // $: any, aValue: number, $a: number

‎tests/fixtures/parser/ast/ts-store01-type-output.svelte

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<script lang="ts">
2-
import { writable } from 'svelte/store'; // writable: <T>(value: T, start?: StartStopNotifier<T> | undefined) => Writable<T>, writable: <T>(value: T, start?: StartStopNotifier<T> | undefined) => Writable<T>
2+
import { writable } from 'svelte/store'; // writable: <T_1>(value?: T_1 | undefined, start?: StartStopNotifier<T_1> | undefined) => Writable<T_1>, writable: <T_1>(value?: T_1 | undefined, start?: StartStopNotifier<T_1> | undefined) => Writable<T_1>
33
const a = writable(0) // a: Writable<number>, writable(0): Writable<number>
44
const b = writable(0) // b: Writable<number>, writable(0): Writable<number>
55
const $b = 'abc' // $b: "abc"

‎tests/fixtures/parser/ast/ts-store02-type-output.svelte

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<script context="module" lang="ts">
2-
import { writable } from 'svelte/store'; // writable: <T>(value: T, start?: StartStopNotifier<T> | undefined) => Writable<T>, writable: <T>(value: T, start?: StartStopNotifier<T> | undefined) => Writable<T>
2+
import { writable } from 'svelte/store'; // writable: <T_1>(value?: T_1 | undefined, start?: StartStopNotifier<T_1> | undefined) => Writable<T_1>, writable: <T_1>(value?: T_1 | undefined, start?: StartStopNotifier<T_1> | undefined) => Writable<T_1>
33
const a = writable(0) // a: Writable<number>, writable(0): Writable<number>
44
declare const $a: string // $a: string
55
</script>

0 commit comments

Comments
 (0)