-
-
Notifications
You must be signed in to change notification settings - Fork 81
Unused CSS Selector warning not appearing #94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Weird. I'm seeing this with sveltejs/template, but I haven't looked into whether this is an issue with the compiler (probably not), the rollup plugin, or the template. We can move this issue once we find out who's causing it. |
It looks like rollup-plugin-svelte is specifically suppressing this warning, and has been for quite a while, which surprised me. I've inquired into what's intended here. |
I'm still not getting warnings. {
"devDependencies": {
"npm-run-all": "^4.1.5",
"rollup": "^2.18.1",
"rollup-plugin-commonjs": "^10.1.0",
"rollup-plugin-livereload": "^1.3.0",
"rollup-plugin-node-resolve": "^5.2.0",
"rollup-plugin-svelte": "^5.2.3",
"rollup-plugin-terser": "^6.1.0",
"sirv-cli": "^1.0.2",
"svelte-routing": "^1.4.2",
"svelte": "^3.23.2"
}
} |
Not sure if that is the actual problem, but you are using some outdated packages:
These rollup dependencies switched to scoped package naming, so you are actually behind my 3 major versions. |
Thanks, didn't help though. I also tried now with a fresh instance of svelte-template. |
@mustafa0x Hi, did you figure this out? I have the same exact issue here.. |
No, I didn't. I still don't get any warnings. |
Line of code that is causing this: The issue where Rich clarifies the motivation: The PR where the code was committed. So, in light of the above it seems this error was supposed to be silenced only Edit: seems like this commit is what caused this error to always be silenced: |
@mustafa0x thank you, that's very helpful! I was just starting to dig into the code myself. :) |
It shows in the REPL, but not when running locally.
The text was updated successfully, but these errors were encountered: