-
Notifications
You must be signed in to change notification settings - Fork 98
Migrate to Prettier v3 #317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks @sosukesuzuki! Are there any plans for prettier to start publishing types for the api? |
We have |
Are there plans for prettier to update the types there? Or should we look into it? |
I've started working on this and will post a PR when I've got the tests passing again. Can we also make a |
Sorry, Prettier core team doesn't maintain |
@prettier/plugin-pug is migrating here: prettier/plugin-pug#411 |
This comment was marked as spam.
This comment was marked as spam.
Is this something that is being worked on? Would you be ok with receiving a PR for this issue? |
#365 is the current PR for this. The plan is to pick it up this or next week. Help is welcome! |
Yes this is a work in progress (there is a draft PR at #365) but we need help to move it along. Maybe you could coordinate with @dummdidumm who also volunteered to help? |
Nice will give it a look and help where I can |
Note to self: When we integrate the new major version of prettier-plugin-svelte which only works for Prettier 3, we have to add additional checks in the VS Code extension since to ensure we're not loading incompatible combinations of Prettier and the Svelte plugin. |
Is this still in the works? We recently migrated to prettier v3 and I'm now having trouble getting VsCode to format svelte files on save. Not sure if the issue lies here or in the vscode extension. |
The PRs are merged, although it is unreleased as of yet https://github.com/sveltejs/prettier-plugin-svelte/blob/master/CHANGELOG.md |
Thank you for the reply, that's very helpful. I'm guessing when the vscode plug-in is updated after release it will resolve the issue. |
Version 3 of this plugin has been released with Prettier v3 support. |
Hi, I am a maintainer at Prettier.
The Prettier team is currently working on v3(still alpha).
v3 will include breaking changes to the plugin interface.
Please see https://github.com/prettier/prettier/releases/tag/3.0.0-alpha.2 for more information.
I created this issue to help major plugins migrate to Prettier v3.
Myself and @fisker have created a migration guide which you can see here:
https://github.com/prettier/prettier/wiki/How-to-migrate-my-plugin-to-support-Prettier-v3%3F
If you have any questions, feel free to mention us. We can help you.
If you have already migrated to Prettier v3, sorry but please close this issue.
The text was updated successfully, but these errors were encountered: