Dismiss error overlay when source is fixed

[Rich-Harris]

The error overlay behaves a little strangely. If you introduce a syntax error then fix it, the error overlay isn't dismissed. If you add insignificant changes like whitespace, the overlay still isn't dismissed (@dominikg could this be related to this?). Eventually, if you add changes that are significant, the overlay goes away, but it feels like it should vanish as soon as the error is fixed.

error-overlay.mov

[dominikg]

should not. That only ignores add_location differences. code changes are sent. What causes the close in the end? May be a vite issue. cc @bluwy

[bluwy]

The error overlay is auto-closed after another HMR update event is sent:

https://github.com/vitejs/vite/blob/fba82d0ff66d2a13393b052dd95df9e180db663c/packages/vite/src/client/client.ts#L83

It might either be that we didn't re-trigger the update event, or the error was somehow still reported after the update.

[dominikg]

Think we need to evict the last working version from cache here
https://github.com/sveltejs/vite-plugin-svelte/blob/1e55af3ebf46c2b852ce847e7f73b89558adfbce/packages/vite-plugin-svelte/src/index.ts#L186

here too: https://github.com/sveltejs/vite-plugin-svelte/blob/1e55af3ebf46c2b852ce847e7f73b89558adfbce/packages/vite-plugin-svelte/src/handle-hot-update.ts#L29

[dominikg]

PR that fixes it: sveltejs/vite-plugin-svelte#371

(didn't move/ref this issue in v-p-s to avoid spilling info)

[dominikg]

Released @sveltejs/[email protected] that includes the pr above

[Rich-Harris]

tested, works great! thanks