fix: revert additional two-way-binding checks (#2508)

This reverts commit 8c080cf.

This reverts #2477. Sadly, the idea didn't work out, as shown by two opened bug reports:

- #2506: A type union can be narrowed on the input, but not on the way back out
- #2494: A generic nested within a bound value is not properly resolved and not falling back to `any` (in #2477 we thought of the generic case, but only for when the generic is the whole value type, not when it's nested)

For these reasons I don't see a way to properly implement #1392 at the moment.

Author: dummdidumm

packages/language-server/src/plugins/typescript/features/RenameProvider.ts

@@ -463,16 +463,8 @@ export class RenameProviderImpl implements RenameProvider {
         const mappedLocations = await Promise.all(
             renameLocations.map(async (loc) => {
                 const snapshot = await snapshots.retrieve(loc.fileName);
-                const text = snapshot.getFullText();
-                const end = loc.textSpan.start + loc.textSpan.length;
 
-                if (
-                    !(snapshot instanceof SvelteDocumentSnapshot) ||
-                    (!isTextSpanInGeneratedCode(text, loc.textSpan) &&
-                        // prevent generated code for bindings from being renamed
-                        // (it's not inside a generate comment because diagnostics should show up)
-                        text.slice(end + 3, end + 27) !== '__sveltets_binding_value')
-                ) {
+                if (!isTextSpanInGeneratedCode(snapshot.getFullText(), loc.textSpan)) {
                     return {
                         ...loc,
                         range: this.mapRangeToOriginal(snapshot, loc.textSpan),

packages/language-server/test/plugins/typescript/features/diagnostics/fixtures/bindings-two-way-check/Legacy.svelte

@@ -1,7 +1,7 @@
-<script lang="ts">
-	import MyComponent from './ComponentB.svelte'
-	let value: Date
-	$: console.log('value:', value)
+<script>
+    export let value;
 </script>
-  
-<MyComponent bind:value />
+
+{#if value}
+    <input bind:value on:change />
+{/if}

packages/language-server/test/plugins/typescript/features/diagnostics/fixtures/bindings-two-way-check/Runes.svelte

@@ -131,12 +131,6 @@ export function handleBinding(
     if (isSvelte5Plus && element instanceof InlineComponent) {
         // To check if property is actually bindable
         element.appendToStartEnd([`${element.name}.$$bindings = '${attr.name}';`]);
-        // To check if the binding is also assigned to the variable (only works when there's no assertion, we can't transform that)
-        if (!isTypescriptNode(attr.expression)) {
-            element.appendToStartEnd([
-                `${expressionStr} = __sveltets_binding_value(${element.originalName}, '${attr.name}');`
-            ]);
-        }
     }
 
     if (element instanceof Element) {

packages/language-server/test/plugins/typescript/features/diagnostics/fixtures/bindings-two-way-check/RunesGeneric.svelte

@@ -39,7 +39,6 @@ export class InlineComponent {
     private startTagEnd: number;
     private isSelfclosing: boolean;
     public child?: any;
-    public originalName = this.node.name;
 
     // Add const $$xxx = ... only if the variable name is actually used
     // in order to prevent "$$xxx is defined but never used" TS hints

packages/language-server/test/plugins/typescript/features/diagnostics/fixtures/bindings-two-way-check/expected_svelte_5.json

@@ -253,16 +253,3 @@ declare function __sveltets_2_isomorphic_component<
 declare function __sveltets_2_isomorphic_component_slots<
     Props extends Record<string, any>, Events extends Record<string, any>, Slots extends Record<string, any>, Exports extends Record<string, any>, Bindings extends string
 >(klass: {props: Props, events: Events, slots: Slots, exports?: Exports, bindings?: Bindings }): __sveltets_2_IsomorphicComponent<__sveltets_2_PropsWithChildren<Props, Slots>, Events, Slots, Exports, Bindings>;
-
-type __sveltets_NonUndefined<T> = T extends undefined ? never : T;
-
-declare function __sveltets_binding_value<
-    // @ts-ignore this is only used for Svelte 5, which knows about the Component type
-    Comp extends typeof import('svelte').Component<any>,
-    Key extends string
->(comp: Comp, key: Key): Key extends keyof import('svelte').ComponentProps<Comp> ?
-    // bail on unknown because it hints at a generic type which we can't properly resolve here
-    // remove undefined because optional properties have it, and would result in false positives
-    unknown extends import('svelte').ComponentProps<Comp>[Key] ? any : __sveltets_NonUndefined<import('svelte').ComponentProps<Comp>[Key]> : any;
-// Overload to ensure typings that only use old SvelteComponent class or something invalid are gracefully handled
-declare function __sveltets_binding_value(comp: any, key: string): any