From 937acbca0b13cd4fcfc049e66513fcede22e39b4 Mon Sep 17 00:00:00 2001 From: Edward <11798919+Winter@users.noreply.github.com> Date: Mon, 26 Aug 2024 20:14:37 +1000 Subject: [PATCH 01/14] feat: Add fixes for block-lang rule --- .../src/rules/block-lang.ts | 66 +++++++++++++++++-- 1 file changed, 61 insertions(+), 5 deletions(-) diff --git a/packages/eslint-plugin-svelte/src/rules/block-lang.ts b/packages/eslint-plugin-svelte/src/rules/block-lang.ts index 1beb94e80..5f5c4f1b7 100644 --- a/packages/eslint-plugin-svelte/src/rules/block-lang.ts +++ b/packages/eslint-plugin-svelte/src/rules/block-lang.ts @@ -1,5 +1,5 @@ import { createRule } from '../utils'; -import { getLangValue } from '../utils/ast-utils'; +import { findAttribute, getLangValue } from '../utils/ast-utils'; import type { SvelteScriptElement, SvelteStyleElement } from 'svelte-eslint-parser/lib/ast'; import { getSourceCode } from '../utils/compat'; @@ -11,6 +11,7 @@ export default createRule('block-lang', { category: 'Best Practices', recommended: false }, + fixable: 'code', schema: [ { type: 'object', @@ -88,7 +89,15 @@ export default createRule('block-lang', { loc: { line: 1, column: 1 }, message: `The \n\n` + ); + } }); } for (const scriptNode of scriptNodes) { @@ -97,7 +106,20 @@ export default createRule('block-lang', { node: scriptNode, message: `The lang attribute of the \n\n` - ); - } + suggest: allowedScriptLangs + .filter((lang) => lang != null && lang !== '') + .map((lang) => { + return { + desc: `Add a \n\n` + ); + } + }; + }) }); } for (const scriptNode of scriptNodes) { if (!allowedScriptLangs.includes(getLangValue(scriptNode)?.toLowerCase() ?? null)) { + const langAttribute = findAttribute(scriptNode, 'lang'); context.report({ node: scriptNode, message: `The lang attribute of the + + diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/javascript/js01-errors.yaml b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/javascript/js01-errors.yaml index f660dd594..be37efdc2 100644 --- a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/javascript/js01-errors.yaml +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/javascript/js01-errors.yaml @@ -1,4 +1,7 @@ - message: The lang attribute of the diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/javascript/null01-errors.yaml b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/javascript/null01-errors.yaml index f660dd594..be37efdc2 100644 --- a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/javascript/null01-errors.yaml +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/javascript/null01-errors.yaml @@ -1,4 +1,7 @@ - message: The lang attribute of the diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/javascript/ts01-errors.yaml b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/javascript/ts01-errors.yaml index f660dd594..be37efdc2 100644 --- a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/javascript/ts01-errors.yaml +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/javascript/ts01-errors.yaml @@ -1,4 +1,7 @@ - message: The lang attribute of the diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/javascript/typescript01-errors.yaml b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/javascript/typescript01-errors.yaml index f660dd594..be37efdc2 100644 --- a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/javascript/typescript01-errors.yaml +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/javascript/typescript01-errors.yaml @@ -1,4 +1,7 @@ - message: The lang attribute of the diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/js/javascript01-errors.yaml b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/js/javascript01-errors.yaml index c49ef5c85..89f15181f 100644 --- a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/js/javascript01-errors.yaml +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/js/javascript01-errors.yaml @@ -1,4 +1,7 @@ - message: The lang attribute of the diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/js/js-as-style-lang01-errors.yaml b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/js/js-as-style-lang01-errors.yaml index c49ef5c85..3832b6f5c 100644 --- a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/js/js-as-style-lang01-errors.yaml +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/js/js-as-style-lang01-errors.yaml @@ -1,4 +1,9 @@ - message: The lang attribute of the + + diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/js/null01-errors.yaml b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/js/null01-errors.yaml index c49ef5c85..89f15181f 100644 --- a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/js/null01-errors.yaml +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/js/null01-errors.yaml @@ -1,4 +1,7 @@ - message: The lang attribute of the diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/js/ts01-errors.yaml b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/js/ts01-errors.yaml index c49ef5c85..89f15181f 100644 --- a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/js/ts01-errors.yaml +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/js/ts01-errors.yaml @@ -1,4 +1,7 @@ - message: The lang attribute of the diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/js/typescript01-errors.yaml b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/js/typescript01-errors.yaml index c49ef5c85..89f15181f 100644 --- a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/js/typescript01-errors.yaml +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/js/typescript01-errors.yaml @@ -1,4 +1,7 @@ - message: The lang attribute of the diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/module-context/javascript01-errors.yaml b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/module-context/javascript01-errors.yaml index b42a142cf..bad06630c 100644 --- a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/module-context/javascript01-errors.yaml +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/module-context/javascript01-errors.yaml @@ -1,4 +1,9 @@ - message: The lang attribute of the + + diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/module-context/js01-errors.yaml b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/module-context/js01-errors.yaml index b42a142cf..bad06630c 100644 --- a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/module-context/js01-errors.yaml +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/module-context/js01-errors.yaml @@ -1,4 +1,9 @@ - message: The lang attribute of the + + diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/module-context/null01-errors.yaml b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/module-context/null01-errors.yaml index b42a142cf..e33140d6f 100644 --- a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/module-context/null01-errors.yaml +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/module-context/null01-errors.yaml @@ -1,4 +1,9 @@ - message: The lang attribute of the + + diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/module-context/ts-as-style-lang01-errors.yaml b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/module-context/ts-as-style-lang01-errors.yaml index b42a142cf..55a6c2475 100644 --- a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/module-context/ts-as-style-lang01-errors.yaml +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/module-context/ts-as-style-lang01-errors.yaml @@ -1,4 +1,11 @@ - message: The lang attribute of the + + + + diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/module-context/typescript01-errors.yaml b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/module-context/typescript01-errors.yaml index b42a142cf..bad06630c 100644 --- a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/module-context/typescript01-errors.yaml +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/module-context/typescript01-errors.yaml @@ -1,4 +1,9 @@ - message: The lang attribute of the + + diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/multiple/javascript01-errors.yaml b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/multiple/javascript01-errors.yaml index 90ac8a74e..5ca79c3f8 100644 --- a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/multiple/javascript01-errors.yaml +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/multiple/javascript01-errors.yaml @@ -2,4 +2,10 @@ one of "ts", "typescript". line: 1 column: 1 - suggestions: null + suggestions: + - desc: Add a + - desc: Add a diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/multiple/js01-errors.yaml b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/multiple/js01-errors.yaml index 90ac8a74e..5ca79c3f8 100644 --- a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/multiple/js01-errors.yaml +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/multiple/js01-errors.yaml @@ -2,4 +2,10 @@ one of "ts", "typescript". line: 1 column: 1 - suggestions: null + suggestions: + - desc: Add a + - desc: Add a diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/multiple/null-as-style-lang01-errors.yaml b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/multiple/null-as-style-lang01-errors.yaml index 90ac8a74e..aa86017f2 100644 --- a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/multiple/null-as-style-lang01-errors.yaml +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/multiple/null-as-style-lang01-errors.yaml @@ -2,4 +2,14 @@ one of "ts", "typescript". line: 1 column: 1 - suggestions: null + suggestions: + - desc: Add a + + + - desc: Add a + + diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/multiple/ts-as-style-lang01-errors.yaml b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/multiple/ts-as-style-lang01-errors.yaml index 90ac8a74e..69682cf06 100644 --- a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/multiple/ts-as-style-lang01-errors.yaml +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/multiple/ts-as-style-lang01-errors.yaml @@ -2,4 +2,14 @@ one of "ts", "typescript". line: 1 column: 1 - suggestions: null + suggestions: + - desc: Add a + + + - desc: Add a + + diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/multiple/typescript-as-style-lang01-errors.yaml b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/multiple/typescript-as-style-lang01-errors.yaml index 90ac8a74e..9462d9f90 100644 --- a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/multiple/typescript-as-style-lang01-errors.yaml +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/multiple/typescript-as-style-lang01-errors.yaml @@ -2,4 +2,14 @@ one of "ts", "typescript". line: 1 column: 1 - suggestions: null + suggestions: + - desc: Add a + + + - desc: Add a + + diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/shorthand/javascript01-errors.yaml b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/shorthand/javascript01-errors.yaml index b42a142cf..07ff7e701 100644 --- a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/shorthand/javascript01-errors.yaml +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/shorthand/javascript01-errors.yaml @@ -1,4 +1,7 @@ - message: The lang attribute of the diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/shorthand/js01-errors.yaml b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/shorthand/js01-errors.yaml index b42a142cf..07ff7e701 100644 --- a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/shorthand/js01-errors.yaml +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/shorthand/js01-errors.yaml @@ -1,4 +1,7 @@ - message: The lang attribute of the diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/shorthand/null01-errors.yaml b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/shorthand/null01-errors.yaml index b42a142cf..07ff7e701 100644 --- a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/shorthand/null01-errors.yaml +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/shorthand/null01-errors.yaml @@ -1,4 +1,7 @@ - message: The lang attribute of the diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/shorthand/ts-as-style-lang01-errors.yaml b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/shorthand/ts-as-style-lang01-errors.yaml index b42a142cf..afc0714fe 100644 --- a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/shorthand/ts-as-style-lang01-errors.yaml +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/shorthand/ts-as-style-lang01-errors.yaml @@ -1,4 +1,9 @@ - message: The lang attribute of the + + diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/shorthand/typescript01-errors.yaml b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/shorthand/typescript01-errors.yaml index b42a142cf..07ff7e701 100644 --- a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/shorthand/typescript01-errors.yaml +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/shorthand/typescript01-errors.yaml @@ -1,4 +1,7 @@ - message: The lang attribute of the diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/ts/javascript01-errors.yaml b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/ts/javascript01-errors.yaml index b42a142cf..07ff7e701 100644 --- a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/ts/javascript01-errors.yaml +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/ts/javascript01-errors.yaml @@ -1,4 +1,7 @@ - message: The lang attribute of the diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/ts/js01-errors.yaml b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/ts/js01-errors.yaml index b42a142cf..07ff7e701 100644 --- a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/ts/js01-errors.yaml +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/ts/js01-errors.yaml @@ -1,4 +1,7 @@ - message: The lang attribute of the diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/ts/null01-errors.yaml b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/ts/null01-errors.yaml index b42a142cf..07ff7e701 100644 --- a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/ts/null01-errors.yaml +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/ts/null01-errors.yaml @@ -1,4 +1,7 @@ - message: The lang attribute of the diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/ts/ts-as-style-lang01-errors.yaml b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/ts/ts-as-style-lang01-errors.yaml index b42a142cf..afc0714fe 100644 --- a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/ts/ts-as-style-lang01-errors.yaml +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/ts/ts-as-style-lang01-errors.yaml @@ -1,4 +1,9 @@ - message: The lang attribute of the + + diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/ts/typescript01-errors.yaml b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/ts/typescript01-errors.yaml index b42a142cf..07ff7e701 100644 --- a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/ts/typescript01-errors.yaml +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/ts/typescript01-errors.yaml @@ -1,4 +1,7 @@ - message: The lang attribute of the diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/typescript/javascript01-errors.yaml b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/typescript/javascript01-errors.yaml index a16e8f39a..fd6d9fa33 100644 --- a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/typescript/javascript01-errors.yaml +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/typescript/javascript01-errors.yaml @@ -1,4 +1,7 @@ - message: The lang attribute of the diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/typescript/js01-errors.yaml b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/typescript/js01-errors.yaml index a16e8f39a..fd6d9fa33 100644 --- a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/typescript/js01-errors.yaml +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/typescript/js01-errors.yaml @@ -1,4 +1,7 @@ - message: The lang attribute of the diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/typescript/null01-errors.yaml b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/typescript/null01-errors.yaml index a16e8f39a..fd6d9fa33 100644 --- a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/typescript/null01-errors.yaml +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/typescript/null01-errors.yaml @@ -1,4 +1,7 @@ - message: The lang attribute of the diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/typescript/ts01-errors.yaml b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/typescript/ts01-errors.yaml index a16e8f39a..fd6d9fa33 100644 --- a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/typescript/ts01-errors.yaml +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/typescript/ts01-errors.yaml @@ -1,4 +1,7 @@ - message: The lang attribute of the diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/typescript/typescript-as-style-lang01-errors.yaml b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/typescript/typescript-as-style-lang01-errors.yaml index a16e8f39a..4013f25ef 100644 --- a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/typescript/typescript-as-style-lang01-errors.yaml +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/typescript/typescript-as-style-lang01-errors.yaml @@ -1,4 +1,9 @@ - message: The lang attribute of the + + diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/style/sass/null01-errors.yaml b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/style/sass/null01-errors.yaml index 9eec70357..c95226d44 100644 --- a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/style/sass/null01-errors.yaml +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/style/sass/null01-errors.yaml @@ -1,4 +1,7 @@ - message: The lang attribute of the diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/style/sass/sass-as-script-lang01-errors.yaml b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/style/sass/sass-as-script-lang01-errors.yaml index 3cd86cbd2..90d406a34 100644 --- a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/style/sass/sass-as-script-lang01-errors.yaml +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/style/sass/sass-as-script-lang01-errors.yaml @@ -1,4 +1,11 @@ - message: The lang attribute of the diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/style/sass/scss01-errors.yaml b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/style/sass/scss01-errors.yaml index 9eec70357..c95226d44 100644 --- a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/style/sass/scss01-errors.yaml +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/style/sass/scss01-errors.yaml @@ -1,4 +1,7 @@ - message: The lang attribute of the diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/style/scss/null01-errors.yaml b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/style/scss/null01-errors.yaml index 7663cab19..57a6b031a 100644 --- a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/style/scss/null01-errors.yaml +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/style/scss/null01-errors.yaml @@ -1,4 +1,7 @@ - message: The lang attribute of the diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/style/scss/sass01-errors.yaml b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/style/scss/sass01-errors.yaml index 7663cab19..7255247c5 100644 --- a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/style/scss/sass01-errors.yaml +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/style/scss/sass01-errors.yaml @@ -1,4 +1,9 @@ - message: The lang attribute of the diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/style/scss/scss-as-script-lang01-errors.yaml b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/style/scss/scss-as-script-lang01-errors.yaml index 748d36368..cfd3f7ec1 100644 --- a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/style/scss/scss-as-script-lang01-errors.yaml +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/style/scss/scss-as-script-lang01-errors.yaml @@ -1,4 +1,9 @@ - message: The lang attribute of the From b4aa903950726fc6240714cb3b409cd7ac8c4894 Mon Sep 17 00:00:00 2001 From: baseballyama Date: Mon, 30 Dec 2024 16:33:20 +0900 Subject: [PATCH 07/14] update fixture --- .../rules/block-lang/invalid/script/javascript/_config.json | 2 +- .../script/javascript/javascript-as-style-lang01-errors.yaml | 2 +- .../script/javascript/javascript-as-style-lang01-input.svelte | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/javascript/_config.json b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/javascript/_config.json index 731bb19bc..04b8a8438 100644 --- a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/javascript/_config.json +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/javascript/_config.json @@ -1,3 +1,3 @@ { - "options": [{ "script": ["javascript"], "style": ["javascript", null] }] + "options": [{ "script": ["javascript"], "style": ["scss", null] }] } diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/javascript/javascript-as-style-lang01-errors.yaml b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/javascript/javascript-as-style-lang01-errors.yaml index 4fe2e382c..3cdc635a2 100644 --- a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/javascript/javascript-as-style-lang01-errors.yaml +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/javascript/javascript-as-style-lang01-errors.yaml @@ -6,4 +6,4 @@ output: | - + diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/javascript/javascript-as-style-lang01-input.svelte b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/javascript/javascript-as-style-lang01-input.svelte index 86a37bd26..9c1c647da 100644 --- a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/javascript/javascript-as-style-lang01-input.svelte +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/javascript/javascript-as-style-lang01-input.svelte @@ -1,3 +1,3 @@ - + From 0199ecf1c9f368cab1c0b1768b31d00ac0cc355a Mon Sep 17 00:00:00 2001 From: baseballyama Date: Mon, 30 Dec 2024 16:35:53 +0900 Subject: [PATCH 08/14] update fixture --- .../javascript/javascript-as-style-lang01-errors.yaml | 9 +++++++++ .../javascript/javascript-as-style-lang01-input.svelte | 2 +- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/javascript/javascript-as-style-lang01-errors.yaml b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/javascript/javascript-as-style-lang01-errors.yaml index 3cdc635a2..1d4327363 100644 --- a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/javascript/javascript-as-style-lang01-errors.yaml +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/javascript/javascript-as-style-lang01-errors.yaml @@ -6,4 +6,13 @@ output: | + +- message: The lang attribute of the diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/javascript/javascript-as-style-lang01-input.svelte b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/javascript/javascript-as-style-lang01-input.svelte index 9c1c647da..86a37bd26 100644 --- a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/javascript/javascript-as-style-lang01-input.svelte +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/javascript/javascript-as-style-lang01-input.svelte @@ -1,3 +1,3 @@ - + From 2e96f177b50863d71a7924b5ccb35a0983552be9 Mon Sep 17 00:00:00 2001 From: baseballyama Date: Mon, 30 Dec 2024 16:38:14 +0900 Subject: [PATCH 09/14] update fixture --- .../block-lang/invalid/script/javascript/_config.json | 2 +- .../javascript/javascript-as-style-lang01-errors.yaml | 9 --------- 2 files changed, 1 insertion(+), 10 deletions(-) diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/javascript/_config.json b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/javascript/_config.json index 04b8a8438..731bb19bc 100644 --- a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/javascript/_config.json +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/javascript/_config.json @@ -1,3 +1,3 @@ { - "options": [{ "script": ["javascript"], "style": ["scss", null] }] + "options": [{ "script": ["javascript"], "style": ["javascript", null] }] } diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/javascript/javascript-as-style-lang01-errors.yaml b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/javascript/javascript-as-style-lang01-errors.yaml index 1d4327363..4fe2e382c 100644 --- a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/javascript/javascript-as-style-lang01-errors.yaml +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/javascript/javascript-as-style-lang01-errors.yaml @@ -7,12 +7,3 @@ -- message: The lang attribute of the From f67546e6fc034882d7294145ed2712ecef7fb88a Mon Sep 17 00:00:00 2001 From: baseballyama Date: Mon, 30 Dec 2024 16:59:54 +0900 Subject: [PATCH 10/14] support null --- .../src/rules/block-lang.ts | 92 +++++++++---------- .../script/javascript/js01-errors.yaml | 2 +- .../script/javascript/ts01-errors.yaml | 2 +- .../javascript/typescript01-errors.yaml | 2 +- .../script/js/javascript01-errors.yaml | 2 +- .../invalid/script/js/ts01-errors.yaml | 2 +- .../script/js/typescript01-errors.yaml | 2 +- .../module-context/javascript01-errors.yaml | 2 +- .../script/module-context/js01-errors.yaml | 2 +- .../module-context/typescript01-errors.yaml | 2 +- .../script/multiple/javascript01-errors.yaml | 4 +- .../invalid/script/multiple/js01-errors.yaml | 4 +- .../multiple/null-as-style-lang01-errors.yaml | 4 +- .../multiple/ts-as-style-lang01-errors.yaml | 4 +- .../typescript-as-style-lang01-errors.yaml | 4 +- .../script/null/javascript01-errors.yaml | 5 +- .../invalid/script/null/js01-errors.yaml | 5 +- .../null/null-as-style-lang01-errors.yaml | 7 +- .../invalid/script/null/ts01-errors.yaml | 5 +- .../script/null/typescript01-errors.yaml | 5 +- .../script/shorthand/javascript01-errors.yaml | 2 +- .../invalid/script/shorthand/js01-errors.yaml | 2 +- .../script/shorthand/typescript01-errors.yaml | 2 +- .../script/ts/javascript01-errors.yaml | 2 +- .../invalid/script/ts/js01-errors.yaml | 2 +- .../script/ts/typescript01-errors.yaml | 2 +- .../typescript/javascript01-errors.yaml | 2 +- .../script/typescript/js01-errors.yaml | 2 +- .../script/typescript/ts01-errors.yaml | 2 +- .../null/null-as-script-lang01-errors.yaml | 7 +- .../invalid/style/null/sass01-errors.yaml | 7 +- .../invalid/style/null/scss01-errors.yaml | 5 +- .../invalid/style/sass/scss01-errors.yaml | 2 +- .../invalid/style/scss/sass01-errors.yaml | 2 +- 34 files changed, 114 insertions(+), 84 deletions(-) diff --git a/packages/eslint-plugin-svelte/src/rules/block-lang.ts b/packages/eslint-plugin-svelte/src/rules/block-lang.ts index 00befaf95..c18249966 100644 --- a/packages/eslint-plugin-svelte/src/rules/block-lang.ts +++ b/packages/eslint-plugin-svelte/src/rules/block-lang.ts @@ -2,6 +2,7 @@ import { createRule } from '../utils/index.js'; import { findAttribute, getLangValue } from '../utils/ast-utils.js'; import type { SvelteScriptElement, SvelteStyleElement } from 'svelte-eslint-parser/lib/ast'; import { getSourceCode } from '../utils/compat.js'; +import type { SuggestionReportDescriptor } from '../types.js'; export default createRule('block-lang', { meta: { @@ -108,34 +109,12 @@ export default createRule('block-lang', { } for (const scriptNode of scriptNodes) { if (!allowedScriptLangs.includes(getLangValue(scriptNode)?.toLowerCase() ?? null)) { - const langAttribute = findAttribute(scriptNode, 'lang'); context.report({ node: scriptNode, message: `The lang attribute of the diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/javascript/ts01-errors.yaml b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/javascript/ts01-errors.yaml index be37efdc2..08f247bd2 100644 --- a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/javascript/ts01-errors.yaml +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/javascript/ts01-errors.yaml @@ -2,6 +2,6 @@ line: 1 column: 1 suggestions: - - desc: Add a diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/javascript/typescript01-errors.yaml b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/javascript/typescript01-errors.yaml index be37efdc2..08f247bd2 100644 --- a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/javascript/typescript01-errors.yaml +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/javascript/typescript01-errors.yaml @@ -2,6 +2,6 @@ line: 1 column: 1 suggestions: - - desc: Add a diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/js/javascript01-errors.yaml b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/js/javascript01-errors.yaml index 89f15181f..b7100ca03 100644 --- a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/js/javascript01-errors.yaml +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/js/javascript01-errors.yaml @@ -2,6 +2,6 @@ line: 1 column: 1 suggestions: - - desc: Add a diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/js/ts01-errors.yaml b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/js/ts01-errors.yaml index 89f15181f..b7100ca03 100644 --- a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/js/ts01-errors.yaml +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/js/ts01-errors.yaml @@ -2,6 +2,6 @@ line: 1 column: 1 suggestions: - - desc: Add a diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/js/typescript01-errors.yaml b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/js/typescript01-errors.yaml index 89f15181f..b7100ca03 100644 --- a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/js/typescript01-errors.yaml +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/js/typescript01-errors.yaml @@ -2,6 +2,6 @@ line: 1 column: 1 suggestions: - - desc: Add a diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/module-context/javascript01-errors.yaml b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/module-context/javascript01-errors.yaml index bad06630c..e94782caf 100644 --- a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/module-context/javascript01-errors.yaml +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/module-context/javascript01-errors.yaml @@ -2,7 +2,7 @@ line: 1 column: 1 suggestions: - - desc: Add a diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/module-context/js01-errors.yaml b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/module-context/js01-errors.yaml index bad06630c..e94782caf 100644 --- a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/module-context/js01-errors.yaml +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/module-context/js01-errors.yaml @@ -2,7 +2,7 @@ line: 1 column: 1 suggestions: - - desc: Add a diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/module-context/typescript01-errors.yaml b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/module-context/typescript01-errors.yaml index bad06630c..e94782caf 100644 --- a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/module-context/typescript01-errors.yaml +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/module-context/typescript01-errors.yaml @@ -2,7 +2,7 @@ line: 1 column: 1 suggestions: - - desc: Add a diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/multiple/javascript01-errors.yaml b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/multiple/javascript01-errors.yaml index 5ca79c3f8..3d6c977cd 100644 --- a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/multiple/javascript01-errors.yaml +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/multiple/javascript01-errors.yaml @@ -3,9 +3,9 @@ line: 1 column: 1 suggestions: - - desc: Add a - - desc: Add a diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/multiple/js01-errors.yaml b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/multiple/js01-errors.yaml index 5ca79c3f8..3d6c977cd 100644 --- a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/multiple/js01-errors.yaml +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/multiple/js01-errors.yaml @@ -3,9 +3,9 @@ line: 1 column: 1 suggestions: - - desc: Add a - - desc: Add a diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/multiple/null-as-style-lang01-errors.yaml b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/multiple/null-as-style-lang01-errors.yaml index aa86017f2..b60330464 100644 --- a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/multiple/null-as-style-lang01-errors.yaml +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/multiple/null-as-style-lang01-errors.yaml @@ -3,12 +3,12 @@ line: 1 column: 1 suggestions: - - desc: Add a - - desc: Add a diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/multiple/ts-as-style-lang01-errors.yaml b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/multiple/ts-as-style-lang01-errors.yaml index 69682cf06..3d88a9dc2 100644 --- a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/multiple/ts-as-style-lang01-errors.yaml +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/multiple/ts-as-style-lang01-errors.yaml @@ -3,12 +3,12 @@ line: 1 column: 1 suggestions: - - desc: Add a - - desc: Add a diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/multiple/typescript-as-style-lang01-errors.yaml b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/multiple/typescript-as-style-lang01-errors.yaml index 9462d9f90..c70d42840 100644 --- a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/multiple/typescript-as-style-lang01-errors.yaml +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/multiple/typescript-as-style-lang01-errors.yaml @@ -3,12 +3,12 @@ line: 1 column: 1 suggestions: - - desc: Add a - - desc: Add a diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/null/javascript01-errors.yaml b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/null/javascript01-errors.yaml index b2d700cdf..48a497641 100644 --- a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/null/javascript01-errors.yaml +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/null/javascript01-errors.yaml @@ -1,4 +1,7 @@ - message: The lang attribute of the diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/null/js01-errors.yaml b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/null/js01-errors.yaml index b2d700cdf..48a497641 100644 --- a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/null/js01-errors.yaml +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/null/js01-errors.yaml @@ -1,4 +1,7 @@ - message: The lang attribute of the diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/null/null-as-style-lang01-errors.yaml b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/null/null-as-style-lang01-errors.yaml index b2d700cdf..a53325cf1 100644 --- a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/null/null-as-style-lang01-errors.yaml +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/null/null-as-style-lang01-errors.yaml @@ -1,4 +1,9 @@ - message: The lang attribute of the + + diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/null/ts01-errors.yaml b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/null/ts01-errors.yaml index b2d700cdf..48a497641 100644 --- a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/null/ts01-errors.yaml +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/null/ts01-errors.yaml @@ -1,4 +1,7 @@ - message: The lang attribute of the diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/null/typescript01-errors.yaml b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/null/typescript01-errors.yaml index b2d700cdf..48a497641 100644 --- a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/null/typescript01-errors.yaml +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/null/typescript01-errors.yaml @@ -1,4 +1,7 @@ - message: The lang attribute of the diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/shorthand/javascript01-errors.yaml b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/shorthand/javascript01-errors.yaml index 07ff7e701..b3113014f 100644 --- a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/shorthand/javascript01-errors.yaml +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/shorthand/javascript01-errors.yaml @@ -2,6 +2,6 @@ line: 1 column: 1 suggestions: - - desc: Add a diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/shorthand/js01-errors.yaml b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/shorthand/js01-errors.yaml index 07ff7e701..b3113014f 100644 --- a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/shorthand/js01-errors.yaml +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/shorthand/js01-errors.yaml @@ -2,6 +2,6 @@ line: 1 column: 1 suggestions: - - desc: Add a diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/shorthand/typescript01-errors.yaml b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/shorthand/typescript01-errors.yaml index 07ff7e701..b3113014f 100644 --- a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/shorthand/typescript01-errors.yaml +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/shorthand/typescript01-errors.yaml @@ -2,6 +2,6 @@ line: 1 column: 1 suggestions: - - desc: Add a diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/ts/javascript01-errors.yaml b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/ts/javascript01-errors.yaml index 07ff7e701..b3113014f 100644 --- a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/ts/javascript01-errors.yaml +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/ts/javascript01-errors.yaml @@ -2,6 +2,6 @@ line: 1 column: 1 suggestions: - - desc: Add a diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/ts/js01-errors.yaml b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/ts/js01-errors.yaml index 07ff7e701..b3113014f 100644 --- a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/ts/js01-errors.yaml +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/ts/js01-errors.yaml @@ -2,6 +2,6 @@ line: 1 column: 1 suggestions: - - desc: Add a diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/ts/typescript01-errors.yaml b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/ts/typescript01-errors.yaml index 07ff7e701..b3113014f 100644 --- a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/ts/typescript01-errors.yaml +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/ts/typescript01-errors.yaml @@ -2,6 +2,6 @@ line: 1 column: 1 suggestions: - - desc: Add a diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/typescript/javascript01-errors.yaml b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/typescript/javascript01-errors.yaml index fd6d9fa33..009d419e2 100644 --- a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/typescript/javascript01-errors.yaml +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/typescript/javascript01-errors.yaml @@ -2,6 +2,6 @@ line: 1 column: 1 suggestions: - - desc: Add a diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/typescript/js01-errors.yaml b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/typescript/js01-errors.yaml index fd6d9fa33..009d419e2 100644 --- a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/typescript/js01-errors.yaml +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/typescript/js01-errors.yaml @@ -2,6 +2,6 @@ line: 1 column: 1 suggestions: - - desc: Add a diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/typescript/ts01-errors.yaml b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/typescript/ts01-errors.yaml index fd6d9fa33..009d419e2 100644 --- a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/typescript/ts01-errors.yaml +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/script/typescript/ts01-errors.yaml @@ -2,6 +2,6 @@ line: 1 column: 1 suggestions: - - desc: Add a diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/style/null/null-as-script-lang01-errors.yaml b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/style/null/null-as-script-lang01-errors.yaml index e476b421b..7455fb148 100644 --- a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/style/null/null-as-script-lang01-errors.yaml +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/style/null/null-as-script-lang01-errors.yaml @@ -1,4 +1,9 @@ - message: The lang attribute of the diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/style/null/sass01-errors.yaml b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/style/null/sass01-errors.yaml index 3685a4a45..676669146 100644 --- a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/style/null/sass01-errors.yaml +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/style/null/sass01-errors.yaml @@ -1,4 +1,9 @@ - message: The lang attribute of the diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/style/null/scss01-errors.yaml b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/style/null/scss01-errors.yaml index 3685a4a45..691a404a7 100644 --- a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/style/null/scss01-errors.yaml +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/style/null/scss01-errors.yaml @@ -1,4 +1,7 @@ - message: The lang attribute of the diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/style/sass/scss01-errors.yaml b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/style/sass/scss01-errors.yaml index c95226d44..e4f5b57b3 100644 --- a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/style/sass/scss01-errors.yaml +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/style/sass/scss01-errors.yaml @@ -2,6 +2,6 @@ line: 1 column: 1 suggestions: - - desc: Add a diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/style/scss/sass01-errors.yaml b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/style/scss/sass01-errors.yaml index 7255247c5..6560001ac 100644 --- a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/style/scss/sass01-errors.yaml +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/style/scss/sass01-errors.yaml @@ -2,7 +2,7 @@ line: 1 column: 1 suggestions: - - desc: Add a \n\n` - ); - } - }; - }) + suggest: buildAddLangSuggestions(allowedStyleLangs, 'style', sourceCode) }); } for (const styleNode of styleNodes) { @@ -148,7 +122,7 @@ export default createRule('block-lang', { message: `The lang attribute of the diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/style/sass/sass-as-script-lang01-errors.yaml b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/style/sass/sass-as-script-lang01-errors.yaml index 90d406a34..d08f5177a 100644 --- a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/style/sass/sass-as-script-lang01-errors.yaml +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/style/sass/sass-as-script-lang01-errors.yaml @@ -2,7 +2,7 @@ line: 5 column: 1 suggestions: - - desc: Add a diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/style/scss/scss-as-script-lang01-errors.yaml b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/style/scss/scss-as-script-lang01-errors.yaml index cfd3f7ec1..cd949e0a2 100644 --- a/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/style/scss/scss-as-script-lang01-errors.yaml +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/block-lang/invalid/style/scss/scss-as-script-lang01-errors.yaml @@ -2,7 +2,7 @@ line: 3 column: 1 suggestions: - - desc: Add a