From 37bb117276c42fe2e2dd4bb2bde635e6f337121b Mon Sep 17 00:00:00 2001 From: yosuke ota Date: Mon, 17 Jun 2024 18:23:23 +0900 Subject: [PATCH 1/3] fix: false positives for import vars with TS in `svelte/valid-compile` --- .../src/shared/svelte-compile-warns/transform/typescript.ts | 3 ++- .../valid-compile/valid/ts/ts-unused-in-script-input.svelte | 5 +++++ 2 files changed, 7 insertions(+), 1 deletion(-) create mode 100644 packages/eslint-plugin-svelte/tests/fixtures/rules/valid-compile/valid/ts/ts-unused-in-script-input.svelte diff --git a/packages/eslint-plugin-svelte/src/shared/svelte-compile-warns/transform/typescript.ts b/packages/eslint-plugin-svelte/src/shared/svelte-compile-warns/transform/typescript.ts index 90f755913..5b4b93e84 100644 --- a/packages/eslint-plugin-svelte/src/shared/svelte-compile-warns/transform/typescript.ts +++ b/packages/eslint-plugin-svelte/src/shared/svelte-compile-warns/transform/typescript.ts @@ -35,7 +35,8 @@ export function transform( ts.ScriptTarget.ESNext, module: ts.ModuleKind.ESNext, importsNotUsedAsValues: ts.ImportsNotUsedAsValues.Preserve, - sourceMap: true + sourceMap: true, + preserveValueImports: true } }); diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/valid-compile/valid/ts/ts-unused-in-script-input.svelte b/packages/eslint-plugin-svelte/tests/fixtures/rules/valid-compile/valid/ts/ts-unused-in-script-input.svelte new file mode 100644 index 000000000..4f6831564 --- /dev/null +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/valid-compile/valid/ts/ts-unused-in-script-input.svelte @@ -0,0 +1,5 @@ + + +{$page} From b4555fe88298133e14b9ad00cfab637a8bc26b3f Mon Sep 17 00:00:00 2001 From: Yosuke Ota Date: Mon, 17 Jun 2024 18:26:33 +0900 Subject: [PATCH 2/3] Create ninety-lobsters-dress.md --- .changeset/ninety-lobsters-dress.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/ninety-lobsters-dress.md diff --git a/.changeset/ninety-lobsters-dress.md b/.changeset/ninety-lobsters-dress.md new file mode 100644 index 000000000..b2f5b97fb --- /dev/null +++ b/.changeset/ninety-lobsters-dress.md @@ -0,0 +1,5 @@ +--- +"eslint-plugin-svelte": patch +--- + +fix: false positives for import vars with TS in `svelte/valid-compile` From 1ea6d9327739bb876c0b3ee473e962f59b023dee Mon Sep 17 00:00:00 2001 From: yosuke ota Date: Mon, 17 Jun 2024 18:27:35 +0900 Subject: [PATCH 3/3] update the order of the options. --- .../src/shared/svelte-compile-warns/transform/typescript.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/eslint-plugin-svelte/src/shared/svelte-compile-warns/transform/typescript.ts b/packages/eslint-plugin-svelte/src/shared/svelte-compile-warns/transform/typescript.ts index 5b4b93e84..8f67547b6 100644 --- a/packages/eslint-plugin-svelte/src/shared/svelte-compile-warns/transform/typescript.ts +++ b/packages/eslint-plugin-svelte/src/shared/svelte-compile-warns/transform/typescript.ts @@ -35,8 +35,8 @@ export function transform( ts.ScriptTarget.ESNext, module: ts.ModuleKind.ESNext, importsNotUsedAsValues: ts.ImportsNotUsedAsValues.Preserve, - sourceMap: true, - preserveValueImports: true + preserveValueImports: true, + sourceMap: true } });