From 2c0e2579e2daf89421e04c045b770a18f1201a90 Mon Sep 17 00:00:00 2001 From: yosuke ota Date: Wed, 31 May 2023 10:51:40 +0900 Subject: [PATCH 1/5] feat: add experimental support for Svelte v4 --- .github/workflows/NodeCI.yml | 34 ++++++++++++++++++++++++++++------ package.json | 6 +++--- 2 files changed, 31 insertions(+), 9 deletions(-) diff --git a/.github/workflows/NodeCI.yml b/.github/workflows/NodeCI.yml index acd241c3c..ab9d5b30a 100644 --- a/.github/workflows/NodeCI.yml +++ b/.github/workflows/NodeCI.yml @@ -19,6 +19,8 @@ jobs: run: |+ pnpm run build pnpm run lint + - name: Type Coverage + run: pnpm run typecov build: runs-on: ubuntu-latest steps: @@ -38,7 +40,31 @@ jobs: matrix: os: [ubuntu-latest] eslint: [7, 8] - node: [14, 16, 17, 18, 20] + node: [16, 17, 18, 20] + steps: + - name: Checkout + uses: actions/checkout@v3 + - uses: pnpm/action-setup@v2 + - name: Setup Node.js ${{ matrix.node }} + uses: actions/setup-node@v3 + with: + node-version: ${{ matrix.node }} + - name: Install ESLint ${{ matrix.eslint }} + run: |+ + pnpm install -D eslint@${{ matrix.eslint }} + rm -rf node_modules + if: matrix.eslint != 8 + - name: Install Packages + run: pnpm install + - name: Test + run: pnpm run test + test-for-svelte-v3: + name: Test for Svelte v3 + runs-on: ${{ matrix.os }} + strategy: + matrix: + os: [ubuntu-latest] + node: [14] steps: - name: Checkout uses: actions/checkout@v3 @@ -53,16 +79,12 @@ jobs: rm -rf node_modules - name: Install ESLint ${{ matrix.eslint }} run: |+ - pnpm install -D eslint@${{ matrix.eslint }} + pnpm install -D svelte@3 rm -rf node_modules - rm -rf pnpm-lock.yaml - if: matrix.eslint != 8 - name: Install Packages run: pnpm install - name: Test run: pnpm run test - - name: Type Coverage - run: pnpm run typecov update-resources: runs-on: ubuntu-latest steps: diff --git a/package.json b/package.json index 29455698d..e1057f789 100644 --- a/package.json +++ b/package.json @@ -59,7 +59,7 @@ }, "peerDependencies": { "eslint": "^7.0.0 || ^8.0.0-0", - "svelte": "^3.37.0" + "svelte": "^3.37.0 || ^4.0.0-0" }, "peerDependenciesMeta": { "svelte": { @@ -163,9 +163,9 @@ "stylelint": "^15.0.0", "stylelint-config-standard": "^33.0.0", "stylus": "^0.59.0", - "svelte": "^3.59.1", + "svelte": "^4.0.0-0", "svelte-adapter-ghpages": "0.1.0", - "svelte-i18n": "^3.4.0", + "svelte-i18n": "^3.6.0", "tslib": "^2.5.0", "type-coverage": "^2.22.0", "typescript": "^5.0.0", From 391b654432ce81357c6938c51d603b1a35b132e8 Mon Sep 17 00:00:00 2001 From: Yosuke Ota Date: Wed, 31 May 2023 10:52:48 +0900 Subject: [PATCH 2/5] Create friendly-toys-end.md --- .changeset/friendly-toys-end.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/friendly-toys-end.md diff --git a/.changeset/friendly-toys-end.md b/.changeset/friendly-toys-end.md new file mode 100644 index 000000000..b56101f29 --- /dev/null +++ b/.changeset/friendly-toys-end.md @@ -0,0 +1,5 @@ +--- +"eslint-plugin-svelte": minor +--- + +feat: add experimental support for Svelte v4 From 7131639241aa94d3bc008892a697f39cc3015803 Mon Sep 17 00:00:00 2001 From: yosuke ota Date: Wed, 31 May 2023 10:58:58 +0900 Subject: [PATCH 3/5] fix lint errors --- .eslintrc.js | 1 + docs-svelte-kit/src/lib/header/Header.svelte | 12 +++++++----- docs-svelte-kit/src/routes/+layout.svelte | 1 + 3 files changed, 9 insertions(+), 5 deletions(-) diff --git a/.eslintrc.js b/.eslintrc.js index 17cf4eb6a..423a96f19 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -33,6 +33,7 @@ module.exports = { usePrettierrc: true, }, ], + "node/no-missing-import": "off", // It's a plugin bug. Should be replaced with eslint-plugin-n. // Repo rule "no-restricted-imports": [ "error", diff --git a/docs-svelte-kit/src/lib/header/Header.svelte b/docs-svelte-kit/src/lib/header/Header.svelte index 29ef06fdb..baec551d6 100644 --- a/docs-svelte-kit/src/lib/header/Header.svelte +++ b/docs-svelte-kit/src/lib/header/Header.svelte @@ -16,6 +16,8 @@
(e.code === "Enter" || e.code === "Space") && handleToggleSidebar()} @@ -44,20 +46,20 @@
- + Logoeslint-plugin-svelte
diff --git a/docs-svelte-kit/src/routes/+layout.svelte b/docs-svelte-kit/src/routes/+layout.svelte index 7eddee2b3..9e0f90ba4 100644 --- a/docs-svelte-kit/src/routes/+layout.svelte +++ b/docs-svelte-kit/src/routes/+layout.svelte @@ -33,6 +33,7 @@ +
Date: Thu, 1 Jun 2023 19:21:25 +0900 Subject: [PATCH 4/5] update svelte-eslint-parser --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index e1057f789..a848d4ca1 100644 --- a/package.json +++ b/package.json @@ -75,7 +75,7 @@ "postcss": "^8.4.5", "postcss-load-config": "^3.1.4", "postcss-safe-parser": "^6.0.0", - "svelte-eslint-parser": "^0.29.0" + "svelte-eslint-parser": "^0.30.0" }, "devDependencies": { "@1stg/browserslist-config": "^1.2.3", From f0e88a154a1464ff901715df77638dbb66eb7c6a Mon Sep 17 00:00:00 2001 From: Yosuke Ota Date: Thu, 1 Jun 2023 19:22:41 +0900 Subject: [PATCH 5/5] Create grumpy-gorillas-sip.md --- .changeset/grumpy-gorillas-sip.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/grumpy-gorillas-sip.md diff --git a/.changeset/grumpy-gorillas-sip.md b/.changeset/grumpy-gorillas-sip.md new file mode 100644 index 000000000..633d46234 --- /dev/null +++ b/.changeset/grumpy-gorillas-sip.md @@ -0,0 +1,5 @@ +--- +"eslint-plugin-svelte": minor +--- + +fix(deps): update dependency svelte-eslint-parser to ^0.30.0