From 296add944ce50fff8a4c873b83f674549eba2a56 Mon Sep 17 00:00:00 2001
From: yosuke ota <otameshiyo23@gmail.com>
Date: Thu, 23 Feb 2023 09:29:26 +0900
Subject: [PATCH 1/2] fix: false positives for read property in
 `svelte/no-dom-manipulating`

---
 src/rules/no-dom-manipulating.ts                          | 2 ++
 .../no-dom-manipulating/valid/read-prop01-input.svelte    | 8 ++++++++
 .../no-dom-manipulating/valid/read-prop02-input.svelte    | 8 ++++++++
 3 files changed, 18 insertions(+)
 create mode 100644 tests/fixtures/rules/no-dom-manipulating/valid/read-prop01-input.svelte
 create mode 100644 tests/fixtures/rules/no-dom-manipulating/valid/read-prop02-input.svelte

diff --git a/src/rules/no-dom-manipulating.ts b/src/rules/no-dom-manipulating.ts
index 5dd5122dd..ef263e525 100644
--- a/src/rules/no-dom-manipulating.ts
+++ b/src/rules/no-dom-manipulating.ts
@@ -78,6 +78,8 @@ export default createRule("no-dom-manipulating", {
         if (parent.left !== target || !DOM_MANIPULATING_PROPERTIES.has(name)) {
           return
         }
+      } else {
+        return
       }
       context.report({
         node: member,
diff --git a/tests/fixtures/rules/no-dom-manipulating/valid/read-prop01-input.svelte b/tests/fixtures/rules/no-dom-manipulating/valid/read-prop01-input.svelte
new file mode 100644
index 000000000..563d334df
--- /dev/null
+++ b/tests/fixtures/rules/no-dom-manipulating/valid/read-prop01-input.svelte
@@ -0,0 +1,8 @@
+<script>
+  let divElement
+  let height = ""
+
+  $: if (divElement) height = `${divElement.clientHeight}px`
+</script>
+
+<div bind:this={divElement} />
diff --git a/tests/fixtures/rules/no-dom-manipulating/valid/read-prop02-input.svelte b/tests/fixtures/rules/no-dom-manipulating/valid/read-prop02-input.svelte
new file mode 100644
index 000000000..59529fcb5
--- /dev/null
+++ b/tests/fixtures/rules/no-dom-manipulating/valid/read-prop02-input.svelte
@@ -0,0 +1,8 @@
+<script>
+  let divElement
+  let foo = ""
+
+  $: if (divElement) foo = `${divElement.data.foo}`
+</script>
+
+<div bind:this={divElement} data-foo="Foo" />

From ce286121deaf02b4665bcf98db530cb460da32fd Mon Sep 17 00:00:00 2001
From: Yosuke Ota <otameshiyo23@gmail.com>
Date: Thu, 23 Feb 2023 09:31:05 +0900
Subject: [PATCH 2/2] Create grumpy-gifts-repeat.md

---
 .changeset/grumpy-gifts-repeat.md | 5 +++++
 1 file changed, 5 insertions(+)
 create mode 100644 .changeset/grumpy-gifts-repeat.md

diff --git a/.changeset/grumpy-gifts-repeat.md b/.changeset/grumpy-gifts-repeat.md
new file mode 100644
index 000000000..ab14a710b
--- /dev/null
+++ b/.changeset/grumpy-gifts-repeat.md
@@ -0,0 +1,5 @@
+---
+"eslint-plugin-svelte": patch
+---
+
+fix: false positives for read property in `svelte/no-dom-manipulating`