diff --git a/.changeset/grumpy-gifts-repeat.md b/.changeset/grumpy-gifts-repeat.md new file mode 100644 index 000000000..ab14a710b --- /dev/null +++ b/.changeset/grumpy-gifts-repeat.md @@ -0,0 +1,5 @@ +--- +"eslint-plugin-svelte": patch +--- + +fix: false positives for read property in `svelte/no-dom-manipulating` diff --git a/src/rules/no-dom-manipulating.ts b/src/rules/no-dom-manipulating.ts index 5dd5122dd..ef263e525 100644 --- a/src/rules/no-dom-manipulating.ts +++ b/src/rules/no-dom-manipulating.ts @@ -78,6 +78,8 @@ export default createRule("no-dom-manipulating", { if (parent.left !== target || !DOM_MANIPULATING_PROPERTIES.has(name)) { return } + } else { + return } context.report({ node: member, diff --git a/tests/fixtures/rules/no-dom-manipulating/valid/read-prop01-input.svelte b/tests/fixtures/rules/no-dom-manipulating/valid/read-prop01-input.svelte new file mode 100644 index 000000000..563d334df --- /dev/null +++ b/tests/fixtures/rules/no-dom-manipulating/valid/read-prop01-input.svelte @@ -0,0 +1,8 @@ + + +
diff --git a/tests/fixtures/rules/no-dom-manipulating/valid/read-prop02-input.svelte b/tests/fixtures/rules/no-dom-manipulating/valid/read-prop02-input.svelte new file mode 100644 index 000000000..59529fcb5 --- /dev/null +++ b/tests/fixtures/rules/no-dom-manipulating/valid/read-prop02-input.svelte @@ -0,0 +1,8 @@ + + +