From 464dda6cb2ff9546bc1ad7fd336659d2487854b6 Mon Sep 17 00:00:00 2001 From: ota-meshi Date: Fri, 3 Feb 2023 23:19:03 +0900 Subject: [PATCH 1/3] fix: update svelte-eslint-parser to v0.23 --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index f708c7a8a..d78e8525a 100644 --- a/package.json +++ b/package.json @@ -73,7 +73,7 @@ "postcss": "^8.4.5", "postcss-load-config": "^3.1.4", "postcss-safe-parser": "^6.0.0", - "svelte-eslint-parser": "^0.22.0" + "svelte-eslint-parser": "^0.23.0" }, "devDependencies": { "@1stg/browserslist-config": "^1.2.3", From ff21b6f80377fa9c550e5e7eaf03ba78829d7537 Mon Sep 17 00:00:00 2001 From: Yosuke Ota Date: Fri, 3 Feb 2023 23:20:10 +0900 Subject: [PATCH 2/3] Create orange-impalas-speak.md --- .changeset/orange-impalas-speak.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/orange-impalas-speak.md diff --git a/.changeset/orange-impalas-speak.md b/.changeset/orange-impalas-speak.md new file mode 100644 index 000000000..f42aadb65 --- /dev/null +++ b/.changeset/orange-impalas-speak.md @@ -0,0 +1,5 @@ +--- +"eslint-plugin-svelte": minor +--- + +fix: update svelte-eslint-parser to v0.23 From b328f4972756e25c72de5da175a81d82ae186f82 Mon Sep 17 00:00:00 2001 From: ota-meshi Date: Fri, 3 Feb 2023 23:34:27 +0900 Subject: [PATCH 3/3] fix: lint error --- src/utils/get-package-json.ts | 7 ++++++- src/utils/svelte-kit.ts | 4 ++-- tests/fixtures/rules/sort-attributes/.eslintrc.js | 5 +++++ 3 files changed, 13 insertions(+), 3 deletions(-) create mode 100644 tests/fixtures/rules/sort-attributes/.eslintrc.js diff --git a/src/utils/get-package-json.ts b/src/utils/get-package-json.ts index 88e1c507c..5076eee6c 100644 --- a/src/utils/get-package-json.ts +++ b/src/utils/get-package-json.ts @@ -6,7 +6,12 @@ import fs from "fs" import path from "path" import { createCache } from "./cache" -type PackageJson = Record & { filePath: string } +type PackageJson = { + name?: unknown + dependencies?: { [key in string]?: unknown } + devDependencies?: { [key in string]?: unknown } + filePath: string +} const isRunOnBrowser = !fs.readFileSync const cache = createCache() diff --git a/src/utils/svelte-kit.ts b/src/utils/svelte-kit.ts index 4e4352a0f..2bb52050f 100644 --- a/src/utils/svelte-kit.ts +++ b/src/utils/svelte-kit.ts @@ -50,8 +50,8 @@ function hasSvelteKit(filePath: string): boolean { // So always it returns true if it runs on the package. return true return Boolean( - packageJson.dependencies["@sveltejs/kit"] ?? - packageJson.devDependencies["@sveltejs/kit"], + packageJson.dependencies?.["@sveltejs/kit"] ?? + packageJson.devDependencies?.["@sveltejs/kit"], ) } catch (_e) { return false diff --git a/tests/fixtures/rules/sort-attributes/.eslintrc.js b/tests/fixtures/rules/sort-attributes/.eslintrc.js new file mode 100644 index 000000000..ba7aa7d28 --- /dev/null +++ b/tests/fixtures/rules/sort-attributes/.eslintrc.js @@ -0,0 +1,5 @@ +module.exports = { + rules: { + "no-use-before-define": "off", + }, +}