diff --git a/.changeset/chilly-olives-check.md b/.changeset/chilly-olives-check.md new file mode 100644 index 000000000..9d85b2b59 --- /dev/null +++ b/.changeset/chilly-olives-check.md @@ -0,0 +1,5 @@ +--- +"eslint-plugin-svelte": patch +--- + +fix: false report in `settings.ignoreWarnings` diff --git a/.github/workflows/NodeCI.yml b/.github/workflows/NodeCI.yml index 53a761d1b..555961e33 100644 --- a/.github/workflows/NodeCI.yml +++ b/.github/workflows/NodeCI.yml @@ -44,6 +44,11 @@ jobs: uses: actions/setup-node@v3 with: node-version: ${{ matrix.node }} + - name: Remove @sveltejs/kit # Remove @sveltejs/kit because postinstall fails on old node. + # Use npm because yarn remove needs the lock file. + run: |+ + npm uninstall @sveltejs/kit --legacy-peer-deps + rm -rf node_modules - name: Install ESLint ${{ matrix.eslint }} run: |+ yarn add -D eslint@${{ matrix.eslint }} --ignore-engines diff --git a/src/rules/system.ts b/src/rules/system.ts index 9a2724a6a..88b15d419 100644 --- a/src/rules/system.ts +++ b/src/rules/system.ts @@ -63,7 +63,7 @@ export default createRule("system", { loc: node.startTag.loc.end, }) if (node.endTag) { - directives.enableBlock(node.endTag.loc.start, isIgnoreRule, { + directives.disableBlock(node.endTag.loc.start, isIgnoreRule, { loc: node.endTag.loc.start, }) } diff --git a/tests/src/settings/ignore-warnings.ts b/tests/src/settings/ignore-warnings.ts index 33ae31832..94ee3a9cc 100644 --- a/tests/src/settings/ignore-warnings.ts +++ b/tests/src/settings/ignore-warnings.ts @@ -10,6 +10,8 @@ describe("ignore-warnings", () => { + {@html a+b} + {@debug a} ` const linter = new eslint.ESLint({ @@ -63,6 +65,10 @@ describe("ignore-warnings", () => { ruleId: "no-undef", line: 5, }, + { + ruleId: "svelte/no-at-html-tags", + line: 7, + }, ], ) }) @@ -73,6 +79,8 @@ describe("ignore-warnings", () => { + {@html a+b} + {@debug a} ` const linter = new eslint.ESLint({ @@ -122,6 +130,10 @@ describe("ignore-warnings", () => { ruleId: "no-undef", line: 5, }, + { + ruleId: "svelte/no-at-html-tags", + line: 7, + }, ], ) }) @@ -133,6 +145,8 @@ describe("ignore-warnings", () => { + {@html a+b} + {@debug a} ` const linter = new eslint.ESLint({