From 6c933ffdd84dd12c899c6689b903582dedf08551 Mon Sep 17 00:00:00 2001 From: yosuke ota Date: Sat, 24 Sep 2022 06:24:47 +0900 Subject: [PATCH 1/4] chore: fix ci --- .github/workflows/NodeCI.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/NodeCI.yml b/.github/workflows/NodeCI.yml index 53a761d1b..433d133d9 100644 --- a/.github/workflows/NodeCI.yml +++ b/.github/workflows/NodeCI.yml @@ -50,7 +50,9 @@ jobs: rm -rf node_modules if: matrix.eslint != 8 - name: Install Packages - run: yarn install --ignore-engines + run: |+ + yarn remove @sveltejs/kit + yarn install --ignore-engines - name: Test run: yarn test - name: Type Coverage From 1c1c058b856f38aa4036f09f770fc1f1f4db84e1 Mon Sep 17 00:00:00 2001 From: yosuke ota Date: Sat, 24 Sep 2022 06:34:20 +0900 Subject: [PATCH 2/4] fix: ci --- .github/workflows/NodeCI.yml | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/.github/workflows/NodeCI.yml b/.github/workflows/NodeCI.yml index 433d133d9..85ee5682d 100644 --- a/.github/workflows/NodeCI.yml +++ b/.github/workflows/NodeCI.yml @@ -49,10 +49,13 @@ jobs: yarn add -D eslint@${{ matrix.eslint }} --ignore-engines rm -rf node_modules if: matrix.eslint != 8 - - name: Install Packages + - name: Remove @sveltejs/kit + # Use npm because yarn remove needs the lock file. run: |+ - yarn remove @sveltejs/kit - yarn install --ignore-engines + npm uninstall @sveltejs/kit + rm -rf node_modules + - name: Install Packages + run: yarn install --ignore-engines - name: Test run: yarn test - name: Type Coverage From 6a908f698768d99f6908ce4144c750eb7075ae95 Mon Sep 17 00:00:00 2001 From: yosuke ota Date: Sat, 24 Sep 2022 06:36:35 +0900 Subject: [PATCH 3/4] fix: ci --- .github/workflows/NodeCI.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/NodeCI.yml b/.github/workflows/NodeCI.yml index 85ee5682d..c5ddd72d3 100644 --- a/.github/workflows/NodeCI.yml +++ b/.github/workflows/NodeCI.yml @@ -49,10 +49,10 @@ jobs: yarn add -D eslint@${{ matrix.eslint }} --ignore-engines rm -rf node_modules if: matrix.eslint != 8 - - name: Remove @sveltejs/kit + - name: Remove @sveltejs/kit # Remove @sveltejs/kit because postinstall fails on old node. # Use npm because yarn remove needs the lock file. run: |+ - npm uninstall @sveltejs/kit + npm uninstall @sveltejs/kit --legacy-peer-deps rm -rf node_modules - name: Install Packages run: yarn install --ignore-engines From a4a361584c2aacd9975bb2a15b87b977391b6ab3 Mon Sep 17 00:00:00 2001 From: yosuke ota Date: Sat, 24 Sep 2022 06:38:41 +0900 Subject: [PATCH 4/4] fix: ci --- .github/workflows/NodeCI.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/NodeCI.yml b/.github/workflows/NodeCI.yml index c5ddd72d3..555961e33 100644 --- a/.github/workflows/NodeCI.yml +++ b/.github/workflows/NodeCI.yml @@ -44,16 +44,16 @@ jobs: uses: actions/setup-node@v3 with: node-version: ${{ matrix.node }} - - name: Install ESLint ${{ matrix.eslint }} - run: |+ - yarn add -D eslint@${{ matrix.eslint }} --ignore-engines - rm -rf node_modules - if: matrix.eslint != 8 - name: Remove @sveltejs/kit # Remove @sveltejs/kit because postinstall fails on old node. # Use npm because yarn remove needs the lock file. run: |+ npm uninstall @sveltejs/kit --legacy-peer-deps rm -rf node_modules + - name: Install ESLint ${{ matrix.eslint }} + run: |+ + yarn add -D eslint@${{ matrix.eslint }} --ignore-engines + rm -rf node_modules + if: matrix.eslint != 8 - name: Install Packages run: yarn install --ignore-engines - name: Test