From d570d157fd03d2385fe3aa33468e628f2c072f02 Mon Sep 17 00:00:00 2001 From: baseballyama Date: Sun, 12 Jan 2025 11:45:16 +0900 Subject: [PATCH 1/2] chore: do not run rule on Svelte 5 with runes --- .changeset/smart-brooms-relax.md | 5 +++++ .../src/rules/infinite-reactive-loop.ts | 12 +++++++++++- .../tests/fixtures/rules/.DS_Store | Bin 0 -> 8196 bytes 3 files changed, 16 insertions(+), 1 deletion(-) create mode 100644 .changeset/smart-brooms-relax.md create mode 100644 packages/eslint-plugin-svelte/tests/fixtures/rules/.DS_Store diff --git a/.changeset/smart-brooms-relax.md b/.changeset/smart-brooms-relax.md new file mode 100644 index 000000000..ee9ebe81f --- /dev/null +++ b/.changeset/smart-brooms-relax.md @@ -0,0 +1,5 @@ +--- +'eslint-plugin-svelte': patch +--- + +chore: do not run `infinite-reactive-loop` rule on Svelte 5 with runes diff --git a/packages/eslint-plugin-svelte/src/rules/infinite-reactive-loop.ts b/packages/eslint-plugin-svelte/src/rules/infinite-reactive-loop.ts index 7f777a9e6..621dfeff5 100644 --- a/packages/eslint-plugin-svelte/src/rules/infinite-reactive-loop.ts +++ b/packages/eslint-plugin-svelte/src/rules/infinite-reactive-loop.ts @@ -378,7 +378,17 @@ export default createRule('infinite-reactive-loop', { unexpectedCall: 'Possibly it may occur an infinite reactive loop because this function may update `{{variableName}}`.' }, - type: 'suggestion' + type: 'suggestion', + // Do not run this rule on Svelte 5 with runes. + conditions: [ + { + svelteVersions: ['3/4'] + }, + { + svelteVersions: ['5'], + runes: [false, 'undetermined'] + } + ] }, create(context) { return { diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/.DS_Store b/packages/eslint-plugin-svelte/tests/fixtures/rules/.DS_Store new file mode 100644 index 0000000000000000000000000000000000000000..1685005caf666eaa1ef1bc2a4f0d0e95ec754cd1 GIT binary patch literal 8196 zcmeHMTWl0n82=2pMStNVnKxTcK51dI3vCF54RgTxWNNGGRKi?96V9 zgjglMfVadLpTtY_Q4-@N#smWi4@93dmB5Q8nE0X(#;8vw_@6nmU|V?bp@zszGUuQF zHfQFW|2wDu767oTXtn^<1At5?m#m70+Z^1_&pC$_St>~)&o*sq+ zri6^g7=ajpxd?FjB*CSwy$P%t{kuap15C2pCwU)KtI}FS)R`jiX7RA{mtB0cf5u0wu!)j-NfXcbWb*t8_ zZESAq*xJ*#YwvXReM?x4x=bA<#NEI?Y+Hr>hM%)s({{%OCu}n~GF-BKJL^~jt}$*Y zHJDMRtCz2+UzyM}5pXM^96D0W+Q*7^aGW*BayZ9oO;-<^^l-a8lh0zx>{GfA&EBBt z+5ztAE?6|0QNlXyL3O~VcaWJO0+Z@Sb>JwKio$$hX;B~61|1`7ISMnyJniacZMY<` zRan0;cB+qQBROw;oLe`bQ@DP7a{^BZn6&G1F)m#?VS(%PWRzLn`a*>1@uj?iZp zRFNA}8^jk9*fyk^qYoy-O4vv{<`Zy`_?L%M@DjWQXW>Km3@*ag@C{sp@8Jiy4nM*# z@EiPvl~|2SkYNoba2>A44cLgSn8Iz?h5fh(_hK3c@DOG(hZY`24~tmBNj#1(;AuRA zFXJotCccC3;`{gkp2PF_C0@Xb_!WMKSMVxc!|V7v{(*nu4M~wysYZBD?z0@cr zr8cQU>J-l|l^J+oX7Ncqq|e(5MGTBqDCyYk7?{|;L+!gO75!c2{j17syv0w!*FoZtH7Ro}Z&mn`!64KV ziS8b{(K7yOE10Tg++>Sf2 zkBWZ)2XP2TaFj~lq~ae#8w==TKm>RWr|@|^g)dV1zlyKn>-Ywq#kYwF??puT7(ba+ z*gIzyHlCl)!Y-u?uH(65G)I|OGp8r5LRji~|KEG(-~Z?2#fBJx7=ix}0$ACT?&+fU zxzkF)du^T0XXxYykDC%QOre2?aC_K}lf3y4L%P-@Un-JQLXwA$|NMu5868Tz|KI!@ OR_wI#{(q0`|9=CdtFayc literal 0 HcmV?d00001 From 819af268a159104c0deff838349836422938eaff Mon Sep 17 00:00:00 2001 From: baseballyama Date: Sun, 12 Jan 2025 23:04:34 +0900 Subject: [PATCH 2/2] remove .DS_Store --- .../tests/fixtures/rules/.DS_Store | Bin 8196 -> 0 bytes 1 file changed, 0 insertions(+), 0 deletions(-) delete mode 100644 packages/eslint-plugin-svelte/tests/fixtures/rules/.DS_Store diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/.DS_Store b/packages/eslint-plugin-svelte/tests/fixtures/rules/.DS_Store deleted file mode 100644 index 1685005caf666eaa1ef1bc2a4f0d0e95ec754cd1..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 8196 zcmeHMTWl0n82=2pMStNVnKxTcK51dI3vCF54RgTxWNNGGRKi?96V9 zgjglMfVadLpTtY_Q4-@N#smWi4@93dmB5Q8nE0X(#;8vw_@6nmU|V?bp@zszGUuQF zHfQFW|2wDu767oTXtn^<1At5?m#m70+Z^1_&pC$_St>~)&o*sq+ zri6^g7=ajpxd?FjB*CSwy$P%t{kuap15C2pCwU)KtI}FS)R`jiX7RA{mtB0cf5u0wu!)j-NfXcbWb*t8_ zZESAq*xJ*#YwvXReM?x4x=bA<#NEI?Y+Hr>hM%)s({{%OCu}n~GF-BKJL^~jt}$*Y zHJDMRtCz2+UzyM}5pXM^96D0W+Q*7^aGW*BayZ9oO;-<^^l-a8lh0zx>{GfA&EBBt z+5ztAE?6|0QNlXyL3O~VcaWJO0+Z@Sb>JwKio$$hX;B~61|1`7ISMnyJniacZMY<` zRan0;cB+qQBROw;oLe`bQ@DP7a{^BZn6&G1F)m#?VS(%PWRzLn`a*>1@uj?iZp zRFNA}8^jk9*fyk^qYoy-O4vv{<`Zy`_?L%M@DjWQXW>Km3@*ag@C{sp@8Jiy4nM*# z@EiPvl~|2SkYNoba2>A44cLgSn8Iz?h5fh(_hK3c@DOG(hZY`24~tmBNj#1(;AuRA zFXJotCccC3;`{gkp2PF_C0@Xb_!WMKSMVxc!|V7v{(*nu4M~wysYZBD?z0@cr zr8cQU>J-l|l^J+oX7Ncqq|e(5MGTBqDCyYk7?{|;L+!gO75!c2{j17syv0w!*FoZtH7Ro}Z&mn`!64KV ziS8b{(K7yOE10Tg++>Sf2 zkBWZ)2XP2TaFj~lq~ae#8w==TKm>RWr|@|^g)dV1zlyKn>-Ywq#kYwF??puT7(ba+ z*gIzyHlCl)!Y-u?uH(65G)I|OGp8r5LRji~|KEG(-~Z?2#fBJx7=ix}0$ACT?&+fU zxzkF)du^T0XXxYykDC%QOre2?aC_K}lf3y4L%P-@Un-JQLXwA$|NMu5868Tz|KI!@ OR_wI#{(q0`|9=CdtFayc