dfeat: add svelte/no-svete-internal

Author: baseballyama

README.md

@@ -385,6 +385,7 @@ These rules relate to better ways of doing things to help you avoid problems:
 | [svelte/no-inline-styles](https://sveltejs.github.io/eslint-plugin-svelte/rules/no-inline-styles/) | disallow attributes and directives that produce inline styles |  |
 | [svelte/no-reactive-functions](https://sveltejs.github.io/eslint-plugin-svelte/rules/no-reactive-functions/) | it's not necessary to define functions in reactive statements | :bulb: |
 | [svelte/no-reactive-literals](https://sveltejs.github.io/eslint-plugin-svelte/rules/no-reactive-literals/) | don't assign literal values in reactive statements | :bulb: |
+| [svelte/no-svelte-internal](https://sveltejs.github.io/eslint-plugin-svelte/rules/no-svelte-internal/) | svelte/internal will be removed in Svelte 6. |  |
 | [svelte/no-unused-class-name](https://sveltejs.github.io/eslint-plugin-svelte/rules/no-unused-class-name/) | disallow the use of a class in the template without a corresponding style |  |
 | [svelte/no-unused-svelte-ignore](https://sveltejs.github.io/eslint-plugin-svelte/rules/no-unused-svelte-ignore/) | disallow unused svelte-ignore comments | :star: |
 | [svelte/no-useless-mustaches](https://sveltejs.github.io/eslint-plugin-svelte/rules/no-useless-mustaches/) | disallow unnecessary mustache interpolations | :wrench: |

docs/rules.md

@@ -58,6 +58,7 @@ These rules relate to better ways of doing things to help you avoid problems:
 | [svelte/no-inline-styles](./rules/no-inline-styles.md)                                   | disallow attributes and directives that produce inline styles                                                                             |          |
 | [svelte/no-reactive-functions](./rules/no-reactive-functions.md)                         | it's not necessary to define functions in reactive statements                                                                             | :bulb:   |
 | [svelte/no-reactive-literals](./rules/no-reactive-literals.md)                           | don't assign literal values in reactive statements                                                                                        | :bulb:   |
+| [svelte/no-svelte-internal](./rules/no-svelte-internal.md)                               | svelte/internal will be removed in Svelte 6.                                                                                              |          |
 | [svelte/no-unused-class-name](./rules/no-unused-class-name.md)                           | disallow the use of a class in the template without a corresponding style                                                                 |          |
 | [svelte/no-unused-svelte-ignore](./rules/no-unused-svelte-ignore.md)                     | disallow unused svelte-ignore comments                                                                                                    | :star:   |
 | [svelte/no-useless-mustaches](./rules/no-useless-mustaches.md)                           | disallow unnecessary mustache interpolations                                                                                              | :wrench: |

docs/rules/no-svelte-internal.md

@@ -0,0 +1,51 @@
+---
+pageClass: 'rule-details'
+sidebarDepth: 0
+title: 'svelte/no-svelte-internal'
+description: 'svelte/internal will be removed in Svelte 6.'
+---
+
+# svelte/no-svelte-internal
+
+> svelte/internal will be removed in Svelte 6.
+
+- :exclamation: <badge text="This rule has not been released yet." vertical="middle" type="error"> **_This rule has not been released yet._** </badge>
+
+## :book: Rule Details
+
+This rule reports ???.
+
+<ESLintCodeBlock>
+
+<!--eslint-skip-->
+
+```svelte
+<script>
+  /* eslint svelte/no-svelte-internal: "error" */
+</script>
+
+<!-- ✓ GOOD -->
+
+<!-- ✗ BAD -->
+```
+
+</ESLintCodeBlock>
+
+## :wrench: Options
+
+```json
+{
+  "svelte/no-svelte-internal": ["error", {}]
+}
+```
+
+-
+
+## :books: Further Reading
+
+-
+
+## :mag: Implementation
+
+- [Rule source](https://github.com/sveltejs/eslint-plugin-svelte/blob/main/src/rules/no-svelte-internal.ts)
+- [Test source](https://github.com/sveltejs/eslint-plugin-svelte/blob/main/tests/src/rules/no-svelte-internal.ts)

src/rule-types.ts

@@ -209,6 +209,11 @@ export interface RuleOptions {
    * @see https://sveltejs.github.io/eslint-plugin-svelte/rules/no-store-async/
    */
   'svelte/no-store-async'?: Linter.RuleEntry<[]>
+  /**
+   * svelte/internal will be removed in Svelte 6.
+   * @see https://sveltejs.github.io/eslint-plugin-svelte/rules/no-svelte-internal/
+   */
+  'svelte/no-svelte-internal'?: Linter.RuleEntry<[]>
   /**
    * disallow `target="_blank"` attribute without `rel="noopener noreferrer"`
    * @see https://sveltejs.github.io/eslint-plugin-svelte/rules/no-target-blank/

src/rules/no-svelte-internal.ts

@@ -0,0 +1,30 @@
+import { createRule } from '../utils';
+
+export default createRule('no-svelte-internal', {
+	meta: {
+		docs: {
+			description: 'svelte/internal will be removed in Svelte 6.',
+			category: 'Best Practices',
+			// TODO Switch to recommended in the major version.
+			// recommended: true,
+			recommended: false
+		},
+		schema: [],
+		messages: {
+			unexpected: 'Importing from svelte/internal is prohibited. This will be removed in Svelte 6.'
+		},
+		type: 'problem'
+	},
+	create(context) {
+		return {
+			ImportDeclaration(node) {
+				if (node.source.value === 'svelte/internal') {
+					context.report({
+						node,
+						messageId: 'unexpected'
+					});
+				}
+			}
+		};
+	}
+});

src/utils/rules.ts

@@ -41,6 +41,7 @@ import noRestrictedHtmlElements from '../rules/no-restricted-html-elements';
 import noShorthandStylePropertyOverrides from '../rules/no-shorthand-style-property-overrides';
 import noSpacesAroundEqualSignsInAttribute from '../rules/no-spaces-around-equal-signs-in-attribute';
 import noStoreAsync from '../rules/no-store-async';
+import noSvelteInternal from '../rules/no-svelte-internal';
 import noTargetBlank from '../rules/no-target-blank';
 import noTrailingSpaces from '../rules/no-trailing-spaces';
 import noUnknownStyleDirectiveProperty from '../rules/no-unknown-style-directive-property';
@@ -105,6 +106,7 @@ export const rules = [
 	noShorthandStylePropertyOverrides,
 	noSpacesAroundEqualSignsInAttribute,
 	noStoreAsync,
+	noSvelteInternal,
 	noTargetBlank,
 	noTrailingSpaces,
 	noUnknownStyleDirectiveProperty,

tests/fixtures/rules/no-svelte-internal/invalid/no-svelte-internal01-errors.yaml

@@ -0,0 +1,4 @@
+- message: Importing from svelte/internal is prohibited. This will be removed in Svelte 6.".
+  line: 2
+  column: 2
+  suggestions: null

tests/fixtures/rules/no-svelte-internal/invalid/no-svelte-internal01-input.svelte

@@ -0,0 +1,3 @@
+<script>
+	import { get_current_component } from 'svelte/internal';
+</script>

tests/fixtures/rules/no-svelte-internal/valid/no-svelte-internal01-input.svelte

@@ -0,0 +1,3 @@
+<script>
+	import { mount } from 'svelte';
+</script>

tests/src/rules/no-svelte-internal.ts

@@ -0,0 +1,12 @@
+import { RuleTester } from '../../utils/eslint-compat';
+import rule from '../../../src/rules/no-svelte-internal';
+import { loadTestCases } from '../../utils/utils';
+
+const tester = new RuleTester({
+	languageOptions: {
+		ecmaVersion: 2020,
+		sourceType: 'module'
+	}
+});
+
+tester.run('no-svelte-internal', rule as any, loadTestCases('no-svelte-internal'));