Skip to content

Commit df9ed9e

Browse files
authored
fix: broken import when not using typescript-eslint (#451)
1 parent fc33676 commit df9ed9e

File tree

2 files changed

+18
-26
lines changed

2 files changed

+18
-26
lines changed

.changeset/great-hornets-fold.md

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"eslint-plugin-svelte": patch
3+
---
4+
5+
fix: broken import when not using typescript-eslint

src/rules/no-reactive-reassign.ts

+13-26
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { TSESTree } from "@typescript-eslint/types"
1+
import type { TSESTree } from "@typescript-eslint/types"
22
import type { AST } from "svelte-eslint-parser"
33
import { createRule } from "../utils"
44
import { getPropertyName } from "@eslint-community/eslint-utils"
@@ -65,19 +65,17 @@ export default createRule("no-reactive-reassign", {
6565
pathNodes?: TSESTree.MemberExpression[]
6666
}
6767
} = {
68-
[TSESTree.AST_NODE_TYPES.UpdateExpression]:
68+
UpdateExpression:
6969
// e.g. foo ++, foo --
7070
({ parent }) => ({ type: "reassign", node: parent }),
71-
[TSESTree.AST_NODE_TYPES.UnaryExpression]: ({
72-
parent,
73-
}: CheckContext<TSESTree.UnaryExpression>) => {
71+
UnaryExpression: ({ parent }: CheckContext<TSESTree.UnaryExpression>) => {
7472
if (parent.operator === "delete") {
7573
// e.g. delete foo.prop
7674
return { type: "reassign", node: parent }
7775
}
7876
return null
7977
},
80-
[TSESTree.AST_NODE_TYPES.AssignmentExpression]: ({
78+
AssignmentExpression: ({
8179
node,
8280
parent,
8381
}: CheckContext<TSESTree.AssignmentExpression>) => {
@@ -87,7 +85,7 @@ export default createRule("no-reactive-reassign", {
8785
}
8886
return null
8987
},
90-
[TSESTree.AST_NODE_TYPES.ForInStatement]: ({
88+
ForInStatement: ({
9189
node,
9290
parent,
9391
}: CheckContext<TSESTree.ForInStatement>) => {
@@ -97,7 +95,7 @@ export default createRule("no-reactive-reassign", {
9795
}
9896
return null
9997
},
100-
[TSESTree.AST_NODE_TYPES.ForOfStatement]: ({
98+
ForOfStatement: ({
10199
node,
102100
parent,
103101
}: CheckContext<TSESTree.ForOfStatement>) => {
@@ -107,7 +105,7 @@ export default createRule("no-reactive-reassign", {
107105
}
108106
return null
109107
},
110-
[TSESTree.AST_NODE_TYPES.CallExpression]: ({
108+
CallExpression: ({
111109
node,
112110
parent,
113111
pathNodes,
@@ -131,7 +129,7 @@ export default createRule("no-reactive-reassign", {
131129
}
132130
return null
133131
},
134-
[TSESTree.AST_NODE_TYPES.MemberExpression]: ({
132+
MemberExpression: ({
135133
node,
136134
parent,
137135
pathNodes,
@@ -146,14 +144,12 @@ export default createRule("no-reactive-reassign", {
146144
}
147145
return null
148146
},
149-
[TSESTree.AST_NODE_TYPES.ChainExpression]: ({
150-
parent,
151-
}: CheckContext<TSESTree.ChainExpression>) => {
147+
ChainExpression: ({ parent }: CheckContext<TSESTree.ChainExpression>) => {
152148
// e.g. `foo?.prop`
153149
// The context to check next.
154150
return { type: "check", node: parent }
155151
},
156-
[TSESTree.AST_NODE_TYPES.ConditionalExpression]: ({
152+
ConditionalExpression: ({
157153
node,
158154
parent,
159155
}: CheckContext<TSESTree.ConditionalExpression>) => {
@@ -163,10 +159,7 @@ export default createRule("no-reactive-reassign", {
163159
// The context to check next for `(test ? foo : bar).prop`.
164160
return { type: "check", node: parent }
165161
},
166-
[TSESTree.AST_NODE_TYPES.Property]: ({
167-
node,
168-
parent,
169-
}: CheckContext<TSESTree.Property>) => {
162+
Property: ({ node, parent }: CheckContext<TSESTree.Property>) => {
170163
if (
171164
parent.value === node &&
172165
parent.parent &&
@@ -177,20 +170,14 @@ export default createRule("no-reactive-reassign", {
177170
}
178171
return null
179172
},
180-
[TSESTree.AST_NODE_TYPES.ArrayPattern]: ({
181-
node,
182-
parent,
183-
}: CheckContext<TSESTree.ArrayPattern>) => {
173+
ArrayPattern: ({ node, parent }: CheckContext<TSESTree.ArrayPattern>) => {
184174
if (parent.elements.includes(node as TSESTree.DestructuringPattern)) {
185175
// The context to check next for `([foo] = obj)`.
186176
return { type: "check", node: parent }
187177
}
188178
return null
189179
},
190-
[TSESTree.AST_NODE_TYPES.RestElement]: ({
191-
node,
192-
parent,
193-
}: CheckContext<TSESTree.RestElement>) => {
180+
RestElement: ({ node, parent }: CheckContext<TSESTree.RestElement>) => {
194181
if (parent.argument === node && parent.parent) {
195182
// The context to check next for `({...foo} = obj)`.
196183
return {

0 commit comments

Comments
 (0)