Skip to content

Commit da0be7b

Browse files
committed
refactor
1 parent 4ac3714 commit da0be7b

File tree

7 files changed

+19
-10
lines changed

7 files changed

+19
-10
lines changed

docs/rules/comment-directive.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ since: 'v0.0.13'
1010

1111
> support comment-directives in HTML template
1212
13-
- :gear: This rule is included in `"plugin:svelte/base"` configuration.
13+
- :gear: This rule is included in all of `"plugin:svelte/base"`, `"plugin:svelte/recommended"`, `"plugin:svelte/recommended-svelte5-without-legacy"` and `"plugin:svelte/recommended-svelte3-4"` configuration.
1414

1515
Sole purpose of this rule is to provide `eslint-disable` functionality in the template HTML.
1616
It supports usage of the following comments:

docs/rules/system.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ since: 'v0.0.13'
1010

1111
> system rule for working this plugin
1212
13-
- :gear: This rule is included in `"plugin:svelte/base"` configuration.
13+
- :gear: This rule is included in all of `"plugin:svelte/base"`, `"plugin:svelte/recommended"`, `"plugin:svelte/recommended-svelte5-without-legacy"` and `"plugin:svelte/recommended-svelte3-4"` configuration.
1414

1515
## :book: Rule Details
1616

packages/eslint-plugin-svelte/src/rules/comment-directive.ts

+6-1
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,12 @@ export default createRule('comment-directive', {
3232
docs: {
3333
description: 'support comment-directives in HTML template',
3434
category: 'System',
35-
configNames: ['base']
35+
configNames: [
36+
'base',
37+
'recommended',
38+
'recommended-svelte5-without-legacy',
39+
'recommended-svelte3-4'
40+
]
3641
},
3742
schema: [
3843
{

packages/eslint-plugin-svelte/src/rules/system.ts

+6-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,12 @@ export default createRule('system', {
88
docs: {
99
description: 'system rule for working this plugin',
1010
category: 'System',
11-
configNames: ['base']
11+
configNames: [
12+
'base',
13+
'recommended',
14+
'recommended-svelte5-without-legacy',
15+
'recommended-svelte3-4'
16+
]
1217
},
1318
schema: [],
1419
messages: {},

packages/eslint-plugin-svelte/src/types.ts

+3-1
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,9 @@ export interface PartialRuleModule {
8686
export interface PartialRuleMetaData {
8787
docs: {
8888
description: string;
89-
configNames: Exclude<ConfigName, 'base'>[] | ['base'];
89+
configNames:
90+
| Exclude<ConfigName, 'base'>[]
91+
| ['base', 'recommended', 'recommended-svelte5-without-legacy', 'recommended-svelte3-4'];
9092
extensionRule?:
9193
| string
9294
| {

packages/eslint-plugin-svelte/tools/render-rules.ts

+1-2
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,7 @@ export default function renderRulesTableContent(
4848
// -----------------------------------------------------------------------------
4949

5050
function toRuleRow(rule: RuleModule) {
51-
const { configNames } = rule.meta.docs;
52-
const mark = `${configNames.includes('base') || configNames.includes('recommended') ? ':star:' : ''}${
51+
const mark = `${rule.meta.docs.configNames.includes('recommended') ? ':star:' : ''}${
5352
rule.meta.fixable ? ':wrench:' : ''
5453
}${rule.meta.hasSuggestions ? ':bulb:' : ''}${rule.meta.deprecated ? ':warning:' : ''}`;
5554
const link = `[${rule.meta.docs.ruleId}](${buildRulePath(rule.meta.docs.ruleName || '')})`;

packages/eslint-plugin-svelte/tools/update-rulesets.ts

+1-3
Original file line numberDiff line numberDiff line change
@@ -72,9 +72,7 @@ const configNames: ConfigName[] = [
7272
for (const configName of configNames) {
7373
const filteredRules = rules.filter((rule) => {
7474
const { configNames } = rule.meta.docs;
75-
return (
76-
(configNames.includes('base') || configNames.includes(configName)) && !rule.meta.deprecated
77-
);
75+
return configNames.includes(configName) && !rule.meta.deprecated;
7876
});
7977
if (filteredRules.length === 0) {
8078
continue;

0 commit comments

Comments
 (0)