fix function argument

Author: baseballyama

src/rules/reference-helpers/svelte-lifecycle.ts

@@ -0,0 +1,53 @@
+import type { TSESTree } from "@typescript-eslint/types"
+import { ReferenceTracker } from "@eslint-community/eslint-utils"
+import type { RuleContext } from "../../types"
+
+type LifeCycleName =
+  | "onMount"
+  | "beforeUpdate"
+  | "afterUpdate"
+  | "onDestroy"
+  | "tick"
+
+/**
+ * Get usage of Svelte life cycle functions.
+ */
+export function* extractSvelteLifeCycleReferences(
+  context: RuleContext,
+  fuctionName: LifeCycleName[] = [
+    "onMount",
+    "beforeUpdate",
+    "afterUpdate",
+    "onDestroy",
+    "tick",
+  ],
+): Generator<{ node: TSESTree.CallExpression; name: string }, void> {
+  const referenceTracker = new ReferenceTracker(
+    context.getSourceCode().scopeManager.globalScope!,
+  )
+  for (const { node, path } of referenceTracker.iterateEsmReferences({
+    svelte: {
+      [ReferenceTracker.ESM]: true,
+      onMount: {
+        [ReferenceTracker.CALL]: fuctionName.includes("onMount"),
+      },
+      beforeUpdate: {
+        [ReferenceTracker.CALL]: fuctionName.includes("beforeUpdate"),
+      },
+      afterUpdate: {
+        [ReferenceTracker.CALL]: fuctionName.includes("afterUpdate"),
+      },
+      onDestroy: {
+        [ReferenceTracker.CALL]: fuctionName.includes("onDestroy"),
+      },
+      tick: {
+        [ReferenceTracker.CALL]: fuctionName.includes("tick"),
+      },
+    },
+  })) {
+    yield {
+      node: node as TSESTree.CallExpression,
+      name: path[path.length - 1],
+    }
+  }
+}

src/rules/valid-context-access.ts

@@ -1,5 +1,6 @@
 import { createRule } from "../utils"
 import { extractContextReferences } from "./reference-helpers/svelte-context"
+import { extractSvelteLifeCycleReferences } from "./reference-helpers/svelte-lifecycle"
 import type { TSESTree } from "@typescript-eslint/types"
 
 export default createRule("valid-context-access", {
@@ -23,8 +24,12 @@ export default createRule("valid-context-access", {
       return {}
     }
 
-    // Extract <script> blocks that is not module=context.
     const sourceCode = context.getSourceCode()
+    const lifeCycleReferences = Array.from(
+      extractSvelteLifeCycleReferences(context),
+    ).map((r) => r.node)
+
+    // Extract <script> blocks that is not module=context.
     const scriptNotModuleElements = sourceCode.ast.body.filter((b) => {
       if (b.type !== "SvelteScriptElement") return false
       const isModule = b.startTag.attributes.some((a) => {
@@ -86,6 +91,8 @@ export default createRule("valid-context-access", {
       return false
     }
 
+    const awaitExpressions: TSESTree.AwaitExpression[] = []
+
     /** Let's lint! */
     function doLint(
       visitedCallExpressions: TSESTree.CallExpression[],
@@ -129,20 +136,23 @@ export default createRule("valid-context-access", {
         } else if (parent?.type === "ExpressionStatement") {
           if (parent.expression.type !== "CallExpression") {
             report(contextCallExpression)
-          } else if (parent.expression.callee.type === "Identifier") {
+          } else if (lifeCycleReferences.includes(parent.expression)) {
             report(contextCallExpression)
           }
         }
       }
     }
 
     return {
-      Program() {
+      "Program:exit"() {
         for (const { node } of extractContextReferences(context)) {
           const visitedCallExpressions: TSESTree.CallExpression[] = []
           doLint(visitedCallExpressions, node, node)
         }
       },
+      AwaitExpression(node) {
+        awaitExpressions.push(node)
+      },
     }
   },
 })

tests/fixtures/rules/valid-context-access/invalid/case08-errors.yaml

@@ -1,3 +1,3 @@
 - message: Do not call setContext except during component initialization.
-  line: 3
-  column: 3
+  line: 6
+  column: 5

tests/fixtures/rules/valid-context-access/invalid/case08-input.svelte

@@ -1,4 +1,9 @@
-<script context="module">
+<script>
   import { setContext } from "svelte"
-  setContext("answer", 42)
+
+  const something = async () => {
+    await Promise.resolve()
+    setContext("answer", 42)
+  }
+  something()
 </script>

tests/fixtures/rules/valid-context-access/invalid/case09-errors.yaml

@@ -0,0 +1,3 @@
+- message: Do not call setContext except during component initialization.
+  line: 3
+  column: 3

tests/fixtures/rules/valid-context-access/invalid/case09-input.svelte

@@ -0,0 +1,4 @@
+<script context="module">
+  import { setContext } from "svelte"
+  setContext("answer", 42)
+</script>

tests/fixtures/rules/valid-context-access/valid/case10-input.svelte

@@ -0,0 +1,6 @@
+<script>
+  import { setContext, onMount } from "svelte"
+
+  const something = (fn) => fn()
+  something(() => setContext("answer", 42))
+</script>