feat(block-lang): Added support for multiple modules of the same type (#511)

Author: marekdedic

.changeset/giant-pillows-shave.md

@@ -0,0 +1,5 @@
+---
+"eslint-plugin-svelte": patch
+---
+
+feat(block-lang): added support for multiple modules of the same type

src/rules/block-lang.ts

@@ -72,29 +72,37 @@ export default createRule("block-lang", {
     const allowedScriptLangs: (string | null)[] = Array.isArray(scriptOption)
       ? scriptOption
       : [scriptOption]
-    let scriptLang: string | null = null
-    let scriptNode: SvelteScriptElement | undefined = undefined
+    const scriptNodes: SvelteScriptElement[] = []
 
     const styleOption: string | null | (string | null)[] =
       context.options[0]?.style ?? null
     const allowedStyleLangs: (string | null)[] = Array.isArray(styleOption)
       ? styleOption
       : [styleOption]
-    let styleLang: string | null = null
-    let styleNode: SvelteStyleElement | undefined = undefined
+    const styleNodes: SvelteStyleElement[] = []
 
     return {
       SvelteScriptElement(node) {
-        scriptNode = node
-        scriptLang = getLangValue(node)?.toLowerCase() ?? null
+        scriptNodes.push(node)
       },
       SvelteStyleElement(node) {
-        styleNode = node
-        styleLang = getLangValue(node)?.toLowerCase() ?? null
+        styleNodes.push(node)
       },
       "Program:exit"() {
-        if (!allowedScriptLangs.includes(scriptLang)) {
-          if (scriptNode !== undefined) {
+        if (scriptNodes.length === 0 && enforceScriptPresent) {
+          context.report({
+            loc: { line: 1, column: 1 },
+            message: `The <script> block should be present and its lang attribute should be ${prettyPrintLangs(
+              allowedScriptLangs,
+            )}.`,
+          })
+        }
+        for (const scriptNode of scriptNodes) {
+          if (
+            !allowedScriptLangs.includes(
+              getLangValue(scriptNode)?.toLowerCase() ?? null,
+            )
+          ) {
             context.report({
               node: scriptNode,
               message: `The lang attribute of the <script> block should be ${prettyPrintLangs(
@@ -103,16 +111,20 @@ export default createRule("block-lang", {
             })
           }
         }
-        if (scriptNode === undefined && enforceScriptPresent) {
+        if (styleNodes.length === 0 && enforceStylePresent) {
           context.report({
             loc: { line: 1, column: 1 },
-            message: `The <script> block should be present and its lang attribute should be ${prettyPrintLangs(
-              allowedScriptLangs,
+            message: `The <style> block should be present and its lang attribute should be ${prettyPrintLangs(
+              allowedStyleLangs,
             )}.`,
           })
         }
-        if (!allowedStyleLangs.includes(styleLang)) {
-          if (styleNode !== undefined) {
+        for (const styleNode of styleNodes) {
+          if (
+            !allowedStyleLangs.includes(
+              getLangValue(styleNode)?.toLowerCase() ?? null,
+            )
+          ) {
             context.report({
               node: styleNode,
               message: `The lang attribute of the <style> block should be ${prettyPrintLangs(
@@ -121,14 +133,6 @@ export default createRule("block-lang", {
             })
           }
         }
-        if (styleNode === undefined && enforceStylePresent) {
-          context.report({
-            loc: { line: 1, column: 1 },
-            message: `The <style> block should be present and its lang attribute should be ${prettyPrintLangs(
-              allowedStyleLangs,
-            )}.`,
-          })
-        }
       },
     }
   },

tests/fixtures/rules/block-lang/invalid/script/module-context/_config.json

@@ -0,0 +1,3 @@
+{
+  "options": [{ "script": ["ts"], "style": ["ts", null] }]
+}

tests/fixtures/rules/block-lang/invalid/script/module-context/javascript01-errors.yaml

@@ -0,0 +1,4 @@
+- message: The lang attribute of the <script> block should be "ts".
+  line: 1
+  column: 1
+  suggestions: null

tests/fixtures/rules/block-lang/invalid/script/module-context/javascript01-input.svelte

@@ -0,0 +1,3 @@
+<script context="module" lang="javascript"></script>
+
+<script lang="ts"></script>

tests/fixtures/rules/block-lang/invalid/script/module-context/js01-errors.yaml

@@ -0,0 +1,4 @@
+- message: The lang attribute of the <script> block should be "ts".
+  line: 1
+  column: 1
+  suggestions: null

tests/fixtures/rules/block-lang/invalid/script/module-context/js01-input.svelte

@@ -0,0 +1,3 @@
+<script context="module" lang="js"></script>
+
+<script lang="ts"></script>

tests/fixtures/rules/block-lang/invalid/script/module-context/null01-errors.yaml

@@ -0,0 +1,4 @@
+- message: The lang attribute of the <script> block should be "ts".
+  line: 1
+  column: 1
+  suggestions: null

tests/fixtures/rules/block-lang/invalid/script/module-context/null01-input.svelte

@@ -0,0 +1,3 @@
+<script context="module"></script>
+
+<script lang="ts"></script>

tests/fixtures/rules/block-lang/invalid/script/module-context/ts-as-style-lang01-errors.yaml

@@ -0,0 +1,4 @@
+- message: The lang attribute of the <script> block should be "ts".
+  line: 1
+  column: 1
+  suggestions: null

tests/fixtures/rules/block-lang/invalid/script/module-context/ts-as-style-lang01-input.svelte

@@ -0,0 +1,5 @@
+<script context="module"></script>
+
+<script lang="ts"></script>
+
+<style lang="ts"></style>

tests/fixtures/rules/block-lang/invalid/script/module-context/typescript01-errors.yaml

@@ -0,0 +1,4 @@
+- message: The lang attribute of the <script> block should be "ts".
+  line: 1
+  column: 1
+  suggestions: null

tests/fixtures/rules/block-lang/invalid/script/module-context/typescript01-input.svelte

@@ -0,0 +1,3 @@
+<script context="module" lang="typescript"></script>
+
+<script lang="ts"></script>